Add support of isort>5

[Mystic-Mirage]

• re-enable pytest-isort after Add isort version 5.0.x support stephrdev/pytest-isort#24

[akaihola]

Oops, I have a competing PR in #15 😄

[Mystic-Mirage]

Oops, I have a competing PR in #15

I'd prefer to add support of isort>5 first and then reimplement #13

[Mystic-Mirage]

@akaihola New isort makes config processing much easier for us.

[akaihola]

I think I managed to reduce unit test hassle a bit by using isort.api.sort_code_string() instead of isort.check_code() and isort.code() in #15.

Edit: Ah, isort.check_code() is an alias for isort.api.check_code_string(), and isort.code() aliases isort.api.sort_code_string(). Good.

[akaihola]

I'd prefer to add support of isort>5 first and then reimplement #13

Ok, yes, let's use your PR, that's probably cleaner.

I had to solve a couple of unit test challenges in #15 – maybe looking at those will help you then with #13?

[akaihola]

Why is this call needed?

[Mystic-Mirage]

This replaces check=True and writes error messages to stdout. See changes in test_main.

[akaihola]

Do we need the error messages?

And if we do, is there a cleaner way to capture them than stdout?

[Mystic-Mirage]

Do we need the error messages?

I don't know... Some tests depend on error messages. Probably, we could raise an exception if check_code is False

And if we do, is there a cleaner way to capture them than stdout?

Hm... isort has hardcoded prints to write to stdout

[akaihola]

Well, I had to include those error messages in the test assertions, because in isort<5 there was no way to get rid of the messages.

Now that we can run isort without polluting stdout with error messages, I think we should do that for simplicity's sake, and fix the tests as well – unless we get some benefit from having those error messages.

[Mystic-Mirage]

I thought check=False in isort<5 was for this?
I vote to get rid of error messages in another PR in order to keep this PR clear.

[akaihola]

I vote to get rid of error messages in another PR in order to keep this PR clear.

I created another PR: #17

[akaihola]

We'll need this in setup.cfg:

[options.extras_require]
isort =
    isort>=5.0.1

(There seems to be a bug in isort 5.0.0)

[Mystic-Mirage]

I had to solve a couple of unit test challenges in #15 – maybe looking at those will help you then with #13?

All tests pass after commenting --isort