Updated extract to handle http receiver metadata #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akats7
force-pushed
the
PR
branch
2 times, most recently
from
c3263c3
to
5e791a9
Compare
akats7
force-pushed
the
PR
branch
2 times, most recently
from
d71850e
to
fad4cbb
Compare
akats7
force-pushed
the
main
branch
2 times, most recently
from
d316feb
to
7239c4a
Compare
**Description:**
I was playing with an erroneous config like the following and noticed
that the error reporting was confusing:
```yaml
processors:
filter:
metrics:
metric:
- true
- false
```
This PR updates the error messages to print the statements next to the
error so it's clear which statement caused the error. To speed up
feedback cycles when changing multiple statements, I've also configured
the parser to attempt to parse each statement so users can see all
errors at once.
Errors now look like this:
```
Error: invalid configuration: processors::filter: unable to parse OTTL statement "drop() where 1": statement has invalid syntax: 1:15: unexpected token "<EOF>" (expected <opcomparison> Value); unable to parse OTTL statement "drop() where 0": statement has invalid syntax: 1:15: unexpected token "<EOF>" (expected <opcomparison> Value)
```
**Testing:** Unit test
Co-authored-by: Evan Bradley <evan-bradley@users.noreply.github.com>
…4213) **Description:** Update go versions used in GitHub workflows. Also changes to a stricter pattern match in some cases to provide more awareness on which version will be selected. --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
…y#24068) **Description:** related open-telemetry#23266 Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation: