[chore] Update go versions used in GitHub workflows #24213

bryan-aguilar · 2023-07-11T20:53:36Z

Description: Update go versions used in GitHub workflows. Also changes to a stricter pattern match in some cases to provide more awareness on which version will be selected.

.github/workflows/build-and-test-windows.yml

MovieStoreGuy · 2023-07-12T07:21:58Z

Please rebase with main

djaglowski · 2023-07-12T14:36:53Z

I've rebased but now we have several integration tests failures in the docker observer:

--- FAIL: TestObserverEmitsEndpointsIntegration (2.19s)
    integration_test.go:53: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/observer/dockerobserver/integration_test.go:53
        	Error:      	Expected nil, but got: &fmt.wrapError{msg:"http: invalid Host header, host port waiting failed: could not start container: creating reaper failed: failed to create container", err:(*fmt.wrapError)(0xc0003df7a0)}
        	Test:       	TestObserverEmitsEndpointsIntegration

jpkrohling · 2023-07-12T14:52:55Z

This test seems to be failing consistently:

--- FAIL: TestObserverEmitsEndpointsIntegration (2.29s)
    integration_test.go:53: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/observer/dockerobserver/integration_test.go:53
        	Error:      	Expected nil, but got: &fmt.wrapError{msg:"http: invalid Host header, host port waiting failed: could not start container: creating reaper failed: failed to create container", err:(*fmt.wrapError)(0xc0003e1960)}
        	Test:       	TestObserverEmitsEndpointsIntegration

bryan-aguilar · 2023-07-12T14:58:46Z

Taking a look

…elemetry-collector-contrib into updateGo1206

bryan-aguilar · 2023-07-12T15:04:31Z

I believe this is the same issue. which may be an issue with testcontainers-go. Currently looking for a workaround.

djaglowski · 2023-07-12T15:29:12Z

@bryan-aguilar, I've made a PR to your branch that would skip all container creation via testcontainers-go. bryan-aguilar#3

bryan-aguilar · 2023-07-12T15:46:24Z

@djaglowski I will write up an issue for these skipped test cases using test containers.

…elemetry-collector-contrib into updateGo1206

codeboten

Looks like another lint failure:

level=info msg="File cache stats: 15 entries of total size 325.0KiB"
	params, ctx, cancel := paramsAndContext(t)
	^
Error: dockerstatsreceiver/integration_test.go:143:2: SA4006: this value of `params` is never used (staticcheck)
	params, ctx, cancel := paramsAndContext(t)
	^

bryan-aguilar · 2023-07-12T16:02:43Z

Yup.....I'm taking a look at this already. fun™

bryan-aguilar · 2023-07-12T16:04:00Z

The linting failure doesn't make sense right now. I can replicate it locally though. That value is used in the 10 line later.

	params, ctx, cancel := paramsAndContext(t)
	defer cancel()

	container := createNginxContainer(ctx, t)

	f, config := factory()
	config.ExcludedImages = append(config.ExcludedImages, "*nginx*")

	consumer := new(consumertest.MetricsSink)
	recv, err := f.CreateMetricsReceiver(ctx, params, config, consumer)

bryan-aguilar · 2023-07-12T16:14:22Z

I suspect dominikh/go-tools#364

djaglowski · 2023-07-12T16:17:08Z

This was written to trick the unused linter, but it may work here too.

bryan-aguilar · 2023-07-12T16:18:37Z

I have ignored the staticcheck linting failures for now.

bryan-aguilar · 2023-07-12T16:34:11Z

 panic: test timed out after 6m0s

goroutine 9233 [running]:
testing.(*M).startAlarm.func1()
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:2036 +0xbb
created by time.goFunc
	/opt/hostedtoolcache/go/1.19.11/x64/src/time/sleep.go:176 +0x48

goroutine 1 [chan receive, 6 minutes]:
testing.(*T).Run(0xc000104680, {0x15aeaeb, 0xf}, 0x1606ce8)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1494 +0x789
testing.runTests.func1(0x0?)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1846 +0x9a
testing.tRunner(0xc000104680, 0xc0005bfba0)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1446 +0x217
testing.runTests(0xc000134820?, {0x1ed1540, 0x9, 0x9}, {0x40?, 0x7f3871831328?, 0x1ee1580?})
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1844 +0x7ed
testing.(*M).Run(0xc000134820)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1726 +0xa85
main.main()
	_testmain.go:65 +0x2ea

goroutine 4 [select]:
go.opencensus.io/stats/view.(*worker).start(0xc0000fca80)
	/home/runner/go/pkg/mod/go.opencensus.io@v0.24.0/stats/view/worker.go:292 +0x185
created by go.opencensus.io/stats/view.init.0
	/home/runner/go/pkg/mod/go.opencensus.io@v0.24.0/stats/view/worker.go:34 +0xf7

goroutine 6 [chan receive, 6 minutes]:
testing.(*T).Run(0xc000104820, {0x15a33de, 0x3}, 0xc00004d750)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1494 +0x789
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver.TestIntegration(0x0?)
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/aerospikereceiver/integration_test.go:31 +0x4a
testing.tRunner(0xc000104820, 0x1606ce8)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1446 +0x217
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1493 +0x75e

goroutine 7 [semacquire, 6 minutes]:
sync.runtime_Semacquire(0xc0004a4178?)
	/opt/hostedtoolcache/go/1.19.11/x64/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc0004a4170)
	/opt/hostedtoolcache/go/1.19.11/x64/src/sync/waitgroup.go:139 +0xa6
github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/scraperinttest.(*IntegrationTest).createContainers(0xc000114580, 0xc000104b60)
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/coreinternal/scraperinttest/scraperint.go:192 +0x1a5
github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/scraperinttest.(*IntegrationTest).Run(0xc000114580, 0xc000104b60)
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/coreinternal/scraperinttest/scraperint.go:76 +0x105
testing.tRunner(0xc000104b60, 0xc00004d750)
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1446 +0x217
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.19.11/x64/src/testing/testing.go:1493 +0x75e
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver	360.041s
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver/cluster	0.027s [no tests to run]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver/cluster/mocks	[no test files]
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver/internal/metadata	0.061s [no tests to run]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/aerospikereceiver/mocks	[no test files]
FAIL
make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/aerospikereceiver'

:(

Could this be a flake? I see it depends on scraperint but it is not skipped.

bryan-aguilar · 2023-07-12T16:36:53Z

I found an additional location containers were being created that was not triggering a skip.

mx-psi · 2023-07-12T16:52:39Z

snmpreceiver/integration_test.go:29:2: SA4006: this value of `testCases` is never used (staticcheck)

bryan-aguilar · 2023-07-12T16:55:17Z

I'm on it. Give me a few. I think I will have a solution that should clear this up.

bryan-aguilar · 2023-07-12T17:13:11Z

Just an update. I'm going to try to use the suggestion @djaglowski made on the skip var workaround. I am planning on moving it to the testutil package so that it can be easily reused. I've hit some snag that are all GoLand IDE related.

bryan-aguilar · 2023-07-12T17:27:04Z

that didn't work. Going back to inserting static check ignores.

bryan-aguilar · 2023-07-12T17:31:34Z

Once this is merged I will prep a PR to remove all the test and static check skips. I will put it into draft status until the upstream dependencies are fixed. But that should expedite the reenablement of the tests.

…issue (#24247) **Description:** Dependent on testcontainers/testcontainers-go#1359 being resolved. Enable tests that were skipped in #24213 **Link to tracking Issue:** #24240

bryan-aguilar added 4 commits July 11, 2023 13:50

Replace with 1.19.11

d266295

Replace 1.19 with stricter pattern match

4d27d8b

Change 1.20 to stricter pattern match for go ver

91b3456

Fix bad search and replace

9273cc3

bryan-aguilar requested review from a team and TylerHelmuth July 11, 2023 20:53

github-actions bot assigned mx-psi Jul 11, 2023

Aneurysm9 approved these changes Jul 11, 2023

View reviewed changes

Fix spacing

0126a5f

TylerHelmuth reviewed Jul 11, 2023

View reviewed changes

.github/workflows/build-and-test-windows.yml Show resolved Hide resolved

dmitryax approved these changes Jul 12, 2023

View reviewed changes

MovieStoreGuy approved these changes Jul 12, 2023

View reviewed changes

bryan-aguilar added 5 commits July 12, 2023 09:51

Replace with 1.19.11

44727c5

Replace 1.19 with stricter pattern match

d6fffc3

Change 1.20 to stricter pattern match for go ver

b47db83

Fix bad search and replace

4b5c340

Fix spacing

220d876

djaglowski force-pushed the updateGo1206 branch from 0126a5f to 220d876 Compare July 12, 2023 13:52

songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 12, 2023

djaglowski mentioned this pull request Jul 12, 2023

[chore][fileconsumer] Fix bug in test where file needs to be reopened #24236

Merged

Merge branch 'updateGo1206' of https://github.com/bryan-aguilar/opent…

69821cb

…elemetry-collector-contrib into updateGo1206

Skip all testcontainers (#3)

77b13a7

bryan-aguilar requested a review from djaglowski as a code owner July 12, 2023 15:44

bryan-aguilar requested a review from a team July 12, 2023 15:44

github-actions bot requested a review from tamir-michaeli July 12, 2023 15:45

mx-psi approved these changes Jul 12, 2023

View reviewed changes

bryan-aguilar mentioned this pull request Jul 12, 2023

Integration tests using test containers are currently skipped #24240

Closed

TylerHelmuth approved these changes Jul 12, 2023

View reviewed changes

Merge branch 'updateGo1206' of https://github.com/bryan-aguilar/opent…

be7b6b7

…elemetry-collector-contrib into updateGo1206

codeboten reviewed Jul 12, 2023

View reviewed changes

Skip staticcheck for skipped tests

eaa42ed

Ignore additional test container creation

57d626c

codeboten approved these changes Jul 12, 2023

View reviewed changes

Ignore static check

494aeea

djaglowski approved these changes Jul 12, 2023

View reviewed changes

djaglowski merged commit 2dde029 into open-telemetry:main Jul 12, 2023
90 checks passed

github-actions bot added this to the next release milestone Jul 12, 2023

bryan-aguilar deleted the updateGo1206 branch July 12, 2023 19:53

bryan-aguilar mentioned this pull request Jul 12, 2023

[chore] Reenable tests and linting disabled due to testconainters-go issue #24247

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore] Update go versions used in GitHub workflows #24213

[chore] Update go versions used in GitHub workflows #24213

bryan-aguilar commented Jul 11, 2023

MovieStoreGuy commented Jul 12, 2023

djaglowski commented Jul 12, 2023

jpkrohling commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

djaglowski commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023 •

edited

Loading

codeboten left a comment

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

djaglowski commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

mx-psi commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

[chore] Update go versions used in GitHub workflows #24213

[chore] Update go versions used in GitHub workflows #24213

Conversation

bryan-aguilar commented Jul 11, 2023

MovieStoreGuy commented Jul 12, 2023

djaglowski commented Jul 12, 2023

jpkrohling commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

djaglowski commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023 • edited Loading

codeboten left a comment

Choose a reason for hiding this comment

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

djaglowski commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

mx-psi commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023

bryan-aguilar commented Jul 12, 2023 •

edited

Loading