Use JUnit5 #691
Merged
Use JUnit5 #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2m
reviewed
Jan 14, 2019
build.sbt
Outdated
| // -a Show stack traces and exception class name for AssertionErrors. | ||
| // -v Log "test run started" / "test started" / "test run finished" events on log level "info" instead of "debug". | ||
| // -q Suppress stdout for successful tests. | ||
| testOptions += Tests.Argument(TestFrameworks.JUnit, "-a", "-v", "-q"), | ||
| testOptions += Tests.Argument(jupiterTestFramework, "-a", "-v", "-q"), |
There was a problem hiding this comment.
It is interesting that with this change these options are still used when running JUnit 4 tests.
There was a problem hiding this comment.
The JUnit 4 tests are now run by Jupiter.
There was a problem hiding this comment.
That makes sense. Then we should be able to get rid of the "com.novocode" % "junit-interface" dependency.
There was a problem hiding this comment.
As it turns out, the Junit 4 tests are not run by the Jupiter runner. When junit-interface is removed they don't run.
testkit/src/main/scala/akka/kafka/testkit/javadsl/KafkaTest.scala
Outdated
Show resolved
Hide resolved
ennru
commented
Jan 14, 2019
testkit/src/main/scala/akka/kafka/testkit/internal/KafkaTestKit.scala
Outdated
Show resolved
Hide resolved
2m
approved these changes
Jan 15, 2019
|
I switched to use the Juniper Vintage Engine to run the JUnit 4 tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits
This PR
KafkaTestandEmbeddedKafkaTestwhich rely on JUnit 5 per-class lifecyleProducerExampleTestandConsumerExampleTestto use JUnit 5 instead