Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange JUnit vintage test name rendering #33

Closed
ennru opened this issue Jan 15, 2019 · 3 comments
Closed

Strange JUnit vintage test name rendering #33

ennru opened this issue Jan 15, 2019 · 3 comments
Milestone

Comments

@ennru
Copy link
Contributor

ennru commented Jan 15, 2019

Now that I figured out to make Jupiter Vintage Engine to run my JUnit 4 tests, I wonder if the test name rendering could be improved.

I get

[info] Test run started (JUnit Vintage)
[info] Test docs.javadsl.AtLeastOnceTestconsumeOneProduceMany(docs.javadsl.AtLeastOnceTest) started
[info] Test docs.javadsl.AtLeastOnceTestconsumerOneProduceConditional(docs.javadsl.AtLeastOnceTest) started

where the test methods are consumeOneProduceMany and consumerOneProduceConditional.

@maichler
Copy link
Contributor

maichler commented Jan 28, 2019

Wow, that sure looks awful !

Could you please check test name rendering with a locally published build of #34 (Branch wip-ticket-33).

The output formatting had to be revised quite a lot. Took a bit of time, sorry for that!

@ennru
Copy link
Contributor Author

ennru commented Jan 28, 2019

👍 I tried it on my project and the Vintage test names now look just like the Jupiter test names.
Your changes seem to be quite big. While at it, would you fix #21 as well?

@maichler
Copy link
Contributor

Great, thanks !

Your changes seem to be quite big.

Mostly tests ensuring that I do not break anything ;)

While at it, would you fix #21 as well?

Please see #21.

@maichler maichler added this to the 0.8.1 milestone Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants