Feature: Add xand tag #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stautis <thkrst@gmail.com>
Feature/xand tag
|
I like the idea, but "xand" isn't really a valid boolean operator! Can we rename it to "and"? To answer your question, I think having a check that xor and and aren't used together would be good. |
|
Thanks for the PR BTW, appreciate it! |
Renaming it to "and" is not a problem. I will also try to make a check for when they are used together, but that might take a bit longer to finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the possibility to add a xand tag.
It works similarly to the xor tag, but requires all flags within the xand group to be set.
I have tried to stay consistent to the style already used, and touch existing functions as little as possible.
The one issue I have not handled here which should probably be resolved before merging is the possibility of a user putting two or more flags in the same xor and xand group, which would cause problems. The reason I have not solved this issue is because I was a bit unsure about how you would like to handle it. Should it be up to the user to check for this when testing their application? Or should kong give an error? Do you have a standard for how you handle issues like this?