Feature/xand tag #1
Conversation
There was a problem hiding this comment.
I think the feature makes sense and your implementation looks good
| @@ -977,6 +1001,20 @@ func checkPassthroughArg(target reflect.Value) bool { | |||
| } | |||
| } | |||
|
|
|||
| func checkXorDuplicatedAndXandMissing(paths []*Path) error { | |||
There was a problem hiding this comment.
I don't exactly see why we'd like to join the errors from checkXorDuplicates() and checkXandMising() here. Is it in case there are variables that are included in both Xor and Xand groups and we have to combine error messages from missing Xors and Xands?
There was a problem hiding this comment.
No, I just thought it would be useful for the user to be told about both duplicated xor flag and missing xand flags in the same error message. So the user do not have to retry several times, and for example first get a message that there are two flags from the same xor group used, and then when fixing this get a new error message that there are missing xand flags and then needing to fix that. So from a user perspective I think it would be best to be told about both problems at the same time.
There was a problem hiding this comment.
Yes, I was slightly worried about breaking the single responsibility principle, but I think it makes sense in this case
Co-authored-by: Stautis <thkrst@gmail.com>
I have added the possibility to add a xand tag.
It works similarly to the xor tag, but requires all flags within the xand group to be set.
I have tried to stay consistent to the style already used, and touch existing functions as little as possible.