Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem /about/usage/system was not tested #609

Merged
merged 9 commits into from
May 3, 2024
Merged

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Apr 29, 2024

Solution: Add a test in pytest and a test in droplet

I had to refactor the setup of the web.app test since pytest-aiohttp use a new async loop between each tests.
Also fixed an issue in get_machine_properties where the returned format is not the same between all the machines. note that this code/dep is going to be dropped in #544 so that's not a blocking issue

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.30%. Comparing base (c7db4ef) to head (f22c753).

Files Patch % Lines
src/aleph/vm/orchestrator/supervisor.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   43.87%   44.30%   +0.43%     
==========================================
  Files          55       55              
  Lines        4978     5006      +28     
  Branches      587      589       +2     
==========================================
+ Hits         2184     2218      +34     
+ Misses       2677     2670       -7     
- Partials      117      118       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh olethanh requested review from hoh and nesitor and removed request for hoh April 30, 2024 13:07
@olethanh olethanh marked this pull request as ready for review April 30, 2024 13:07
@olethanh olethanh changed the title CI check system usage endpoint Problem /about/usage/system was not tested Apr 30, 2024
@nesitor
Copy link
Member

nesitor commented Apr 30, 2024

I think that on Alie's PR (#544) he had installed also the needed packages needed on the installation step.
I don't know if that PR merges also his changes, but if it does, please, can you also add it to this PR? And if not, can you link as dependent this PR to the old one to merge both at the same time?

Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@olethanh
Copy link
Collaborator Author

I think that on Alie's PR (#544) he had installed also the needed packages needed on the installation step. I don't know if that PR merges also his changes, but if it does, please, can you also add it to this PR? And if not, can you link as dependent this PR to the old one to merge both at the same time?

Alie's PR is not included into this one, in that other PR the deps have changed but here they stay the same so normally the installation step shouldn't change, unless I have missed something?

@olethanh olethanh requested a review from nesitor May 2, 2024 10:05
@olethanh olethanh merged commit 47f1ab5 into main May 3, 2024
23 checks passed
@Psycojoker Psycojoker deleted the ol-check-usage-system branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants