-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem /about/usage/system was not tested #609
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 43.87% 44.30% +0.43%
==========================================
Files 55 55
Lines 4978 5006 +28
Branches 587 589 +2
==========================================
+ Hits 2184 2218 +34
+ Misses 2677 2670 -7
- Partials 117 118 +1 ☔ View full report in Codecov by Sentry. |
551cc3f
to
e58b9ad
Compare
9e6b13a
to
6e84b26
Compare
I think that on Alie's PR (#544) he had installed also the needed packages needed on the installation step. |
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Alie's PR is not included into this one, in that other PR the deps have changed but here they stay the same so normally the installation step shouldn't change, unless I have missed something? |
Solution: Add a test in pytest and a test in droplet
I had to refactor the setup of the web.app test since pytest-aiohttp use a new async loop between each tests.
Also fixed an issue in
get_machine_properties
where the returned format is not the same between all the machines. note that this code/dep is going to be dropped in #544 so that's not a blocking issue