Problem: allocation endpoints was not tested #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
reviewed
Apr 30, 2024
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 44.30% 44.82% +0.51%
==========================================
Files 55 55
Lines 5006 5033 +27
Branches 589 589
==========================================
+ Hits 2218 2256 +38
+ Misses 2670 2654 -16
- Partials 118 123 +5 ☔ View full report in Codecov by Sentry. |
olethanh
force-pushed
the
ol-test-allocation-endpoints
branch
from
cbca185
to
47cbca6
Compare
nesitor
reviewed
Apr 30, 2024
nesitor
approved these changes
Apr 30, 2024
Solution: Start by adding some simple tests We don't test the full allocation and deallocation here. just auth
Co-authored-by: nesitor <amolinsdiaz@yahoo.es>
olethanh
force-pushed
the
ol-test-allocation-endpoints
branch
from
6c07ba7
to
0eccb80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on the system usage branch #609 because it need some common modification on the way the supervisor app is setup. So that other PR should be merged first