Remove new line from basic auth (rack#185)

* Fixes rack#64 - Removes new line from basic auth * Fixed grammar
alex-damian-negru · Apr 5, 2021 · b8f3b95 · b8f3b95
1 parent cde0622
commit b8f3b95
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/History.md b/History.md
@@ -1,3 +1,6 @@
+## vNext / 2017-xx-xx
+  * Remove new line from basic auth. (Felix Kleinschmidt #185, closes #64)
+
 ## 0.7.0 / 2017-07-10
 
 * Major enhancements

diff --git a/lib/rack/test.rb b/lib/rack/test.rb
@@ -160,7 +160,7 @@ def env(name, value)
       # Example:
       #   basic_authorize "bryan", "secret"
       def basic_authorize(username, password)
-        encoded_login = ["#{username}:#{password}"].pack("m*")
+        encoded_login = ["#{username}:#{password}"].pack("m0")
         header('Authorization', "Basic #{encoded_login}")
       end
 

diff --git a/spec/rack/test_spec.rb b/spec/rack/test_spec.rb
@@ -339,20 +339,20 @@ def close
     end
   end
 
-  describe "#authorize" do
+  describe "#basic_authorize" do
     it "sets the HTTP_AUTHORIZATION header" do
       authorize "bryan", "secret"
       request "/"
 
-      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0\n")
+      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0")
     end
 
     it "includes the header for subsequent requests" do
       basic_authorize "bryan", "secret"
       request "/"
       request "/"
 
-      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0\n")
+      expect(last_request.env["HTTP_AUTHORIZATION"]).to eq("Basic YnJ5YW46c2VjcmV0")
     end
   end