Remove new line from basic auth

[absrd]

closes #64

[perlun]

Makes sense. Thanks!

[junaruga]

Umm, this PR's traivs test does not complete ..
@absrd Can you rebase your commit message or something to restart Travis?

git commit --amend
git push xxxxx your_branch -f

[absrd]

@junaruga Done

[junaruga]

@absrd thanks!
@perlun the Travis test still does not start. Do you know why?

[dennissivia]

@junaruga Even though I think the change is nice in the sense, that it will make future uses easier to write/read, I just want to want to mention that this looks like a breaking change to the public API. Isn't it?

[perlun]

@scepticulous

Even though I think the change is nice in the sense, that it will make future uses easier to write/read, I just want to want to mention that this looks like a breaking change to the public API. Isn't it?

Technically yes, but the previous approach is clearly wrong. Newlines should not be included in the HTTP headers.

So, in that sense it is a "bug fix" because the previous approach is incorrect. I think it's permissible by SemVer rationale to include bug fixes like this. (and, we aren't at 1.0 yet so in that sense "anything is permissible", even though we must of course be careful with the thousands/millions of people who use the gem)

[dennissivia]

Good point. You are right, we are not creating a valid real world header, thus I agree with it being a bugfix. Thanks.

[perlun]

Thanks. I'm unsure why Travis fails on this one, will download it locally and test it before merge as a workaround.

[perlun]

Works fine for me, let's merge and hope Travis runs correctly after that. Thanks @absrd for your contribution! 👏