Skip to content

Commit

Permalink
test: add EOVERFLOW as an allowed error
Browse files Browse the repository at this point in the history
in test-fs-read-promises-position-validation.mjs

As stated in nodejs#50054

This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.

Fixes nodejs#50054

PR-URL: nodejs#50128
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
  • Loading branch information
abmusse authored and alexfernandez committed Nov 1, 2023
1 parent 1279eb6 commit 24946a1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/parallel/test-fs-read-promises-position-validation.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ async function testInvalid(code, position) {
await testValid(1n);
await testValid(9);
await testValid(9n);
await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG' ]);
await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG', 'EOVERFLOW']);

await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG' ]);
await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG', 'EOVERFLOW']);
await testInvalid('ERR_OUT_OF_RANGE', 2n ** 63n);
await testInvalid('ERR_OUT_OF_RANGE', 2n ** 63n - BigInt(length));

Expand Down

0 comments on commit 24946a1

Please sign in to comment.