Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: parallel/test-fs-read-promises-position-validation fails on IBM i #50054

Closed
richardlau opened this issue Oct 5, 2023 · 0 comments · Fixed by #50128
Closed

test: parallel/test-fs-read-promises-position-validation fails on IBM i #50054

richardlau opened this issue Oct 5, 2023 · 0 comments · Fixed by #50128
Labels
ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.

Comments

@richardlau
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-ibmi/nodes=ibmi73-ppc64/1316/consoleFull

09:20:12 not ok 1103 parallel/test-fs-read-promises-position-validation
09:20:12   ---
09:20:12   duration_ms: 1801.82400
09:20:12   severity: fail
09:20:12   exitcode: 1
09:20:12   stack: |-
09:20:12     node:internal/process/esm_loader:40
09:20:12           internalBinding('errors').triggerUncaughtException(
09:20:12                                     ^
09:20:12     
09:20:12     [Error: EOVERFLOW: value too large for defined data type, read] {
09:20:12       errno: -127,
09:20:12       code: 'EOVERFLOW',
09:20:12       syscall: 'read'
09:20:12     }
09:20:12     
09:20:12     Node.js v21.0.0-pre
09:20:12   ...

This test was introduced by #42835 last week.

Initial glance suggests it's an oversight:

node/test/parallel/test-fs-read-promises-position-validation.mjs

Lines 65 to 67 in b55adfb

await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG' ]);
await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG' ]);

compared to the non-promises test (test-fs-read-position-validation.mjs)

node/test/parallel/test-fs-read-position-validation.mjs

Lines 74 to 76 in 23cb478

await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG', 'EOVERFLOW' ]);
await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG', 'EOVERFLOW' ]);

cc @nodejs/platform-ibmi
@richardlau richardlau added test Issues and PRs related to the tests. ibm i Issues and PRs related to the IBM i platform. labels Oct 5, 2023
@abmusse abmusse mentioned this issue Oct 10, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Oct 12, 2023
@abmusse
test: add EOVERFLOW as an allowed error
f0e720a 
in test-fs-read-promises-position-validation.mjs

As stated in #50054

This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.

Fixes #50054

PR-URL: #50128
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@abmusse @alexfernandez
test: add EOVERFLOW as an allowed error
24946a1 
in test-fs-read-promises-position-validation.mjs

As stated in nodejs#50054

This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.

Fixes nodejs#50054

PR-URL: nodejs#50128
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add EOVERFLOW as an allowed error abmusse/node
1 participant
@richardlau