Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin asdl and vendor previous version in laplace.third_party #224

Closed
wants to merge 1 commit into from

Conversation

kourbou
Copy link
Contributor

@kourbou kourbou commented Aug 19, 2024

This PR fixes pip installation on main by pinning the version of asdl to commit 011a942 and vendoring the previous version in laplace.third_party. I've copied over the LICENSE file from asdl but feel free to let me know how else I can give proper attribution. Maybe we should consider linking the original source in a doc-string in __init__.py.

@aleximmer aleximmer mentioned this pull request Aug 19, 2024
@aleximmer
Copy link
Owner

Thanks for preparing this draft. If we go down this route, I would suggest removing all functionality that we do not need, for example fr.py and hessian.py and precondition.py could be such examples. Should be easy to check for dependencies automatically and keep what's required. Or is there some argument for keeping all old functionality as well?

@kourbou
Copy link
Contributor Author

kourbou commented Aug 19, 2024

Yes, we can remove unused submodules. Test coverage for the old backend should be good enough for keeping only relevant code. I think the argument in favor of keeping all the code is if users of laplace-torch want to re-use other components of ASDL in a same project, but then it's better for them to migrate to the new backend anyways?

@wiseodd
Copy link
Collaborator

wiseodd commented Aug 20, 2024

We decided to go with #225. Thanks a lot, nevertheless, @kourbou!

@wiseodd wiseodd closed this Aug 20, 2024
@aleximmer aleximmer reopened this Aug 20, 2024
@aleximmer
Copy link
Owner

Closed due to #238, which integrates a pruned and formatted version of asdfghjkl. Thanks for the idea and draft @kourbou!

@aleximmer aleximmer closed this Sep 1, 2024
@kourbou kourbou deleted the pin-and-vendor-asdl branch September 26, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants