Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importing asdfghjkl conditional to the installed optional dependency #225

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Aug 19, 2024

@runame @aleximmer please review.

This should make pip install laplace-torch work with or without the old asdfghjkl dependency. To try this:

pip install -e .
pytest

pip install git+https://git@github.com/wiseodd/asdl@asdfghjkl
pytest

@runame if everything is good in this PR, you can directly upload it on PyPi.

Also, if you know a more elegant solution, please let me know.

@wiseodd wiseodd added the documentation Improvements or additions to documentation label Aug 19, 2024
@wiseodd wiseodd self-assigned this Aug 19, 2024
@wiseodd
Copy link
Collaborator Author

wiseodd commented Aug 19, 2024

Added both cases above to the CI.

Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for @aleximmer to approve it as well.

@wiseodd wiseodd merged commit 4e7b9cf into main Aug 20, 2024
3 checks passed
@wiseodd wiseodd deleted the asdfghjkl branch August 20, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants