-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the metadata into setup.cfg. #3
Conversation
KOLANICH
commented
Feb 12, 2020
- ignored some stuff
Hi, can you explain what the goal/purpose of these PRs is? What would be the procedure to release a new version of a package? Can you fix the travis build? |
|
Does this have something to do with IPython? |
Yes, I have installed a new version of ipython from git and noticed a new dependency; I have looked into it and its dependencies and disliked the way they are packaged, so I have sent PRs to them. Fortunately with the help of setuptools_py2cfg converting the metadata was pretty easy. |
Please add pep517 as a test dependency to make packaging easier, and make a shell script out of these steps you just gave. |
It is not trivial to read the previous tag describing a version, and increment it in bash. And versions, if they are SemVers, must be incremented by a human.
Added to extras and not added to |
The version can be an argument which I type in manually. I just don't want to have to remember and manually enter three commands. |
Anyway, thanks for your help and for teaching me new things. Before I merge anything, can you also make the same changes in |
+ upgraded setuptools + now using pep517 for build + ignored some stuff + made coverage compute branch coverage + made pytest emit a file with the report
Next time I want to release a change, I will test this branch out in practice. I'm not keen to merge into master a new set of tools that I'm completely unfamiliar with. |
OK, I tried using this in practice and ran into a couple of problems. Firstly, no matter how I run the script, the argument detection fails and it tells me to provide a version:
Secondly, how am I meant to work with |
OK, I fixed the problems and merged in #7. |
Thank you for this contribution @KOLANICH, I've learned some new stuff! Can you similarly update your PRs for executing and pure_eval? |