Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues in my PR. #52

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Fixing issues in my PR. #52

merged 1 commit into from
Feb 23, 2020

Conversation

KOLANICH
Copy link
Contributor

No description provided.

@dsagal
Copy link
Member

dsagal commented Feb 22, 2020

Thanks, but would you mind explaining these changes? Are the new setup_requires requirements actually necessary?

@alexmojaki
Copy link
Contributor

Some background: I recently merged in a PR which makes asttokens a dependency of IPython (in git master at least) via stack_data. @KOLANICH saw the new dependencies and wanted to update how they're packaged. They've made similar PRs in my 3 packages which also became dependencies. You can maybe get answers to some of your questions in one of those PRs here.

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Feb 22, 2020

Are the new setup_requires requirements actually necessary?

Yes.
"setuptools_scm[toml]>=3.4.3" is required because we use newly introduced support for pyproject.toml in it.

setuptools>=44 is needed because earlier versions won't use pyproject.toml, so setuptools_scm specified in it won't be called, so it won't generate the version file, so the lib will error on importing it. That's why we duplicate it into setup.cfg to make sure earlier versions can use this information and install and use the needed tools.

Of course we can use an older deprecated approach, but IMHO it makes no sense, it is not a problem to install new versions of setuptools and setuptools_scm.

+ branch coverage
+ tests report (useless for travis, but useful for appveyor and gitlab, if you wanna port to it)
@dsagal dsagal merged commit cae7ddc into gristlabs:master Feb 23, 2020
@KOLANICH KOLANICH deleted the setup.cfg branch February 23, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants