Enable listing contents of subfolders on the SAF #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EternityForest
changed the title
|
Thanks for the PR! I'll take a look at the related issue, this PR and and merge this. @all-contributors add EternityForest for code, docs |
|
@lakscastro I've put up a pull request to add @EternityForest! 🎉 |
|
Awesome! Thanks for the wonderful library! |
alexrintt
reviewed
Jun 14, 2022
Comment on lines
+172
to
+178
| try { | ||
| // for childs and sub child dirs | ||
| childrenUritmp = DocumentsContract.buildChildDocumentsUriUsingTree(rootUri, DocumentsContract.getDocumentId(rootUri)); | ||
| } catch (e: Exception) { | ||
| // for parent dir | ||
| childrenUritmp = DocumentsContract.buildChildDocumentsUriUsingTree(rootUri, DocumentsContract.getTreeDocumentId(rootUri)); | ||
| } |
There was a problem hiding this comment.
This makes a lot of sense. I knew something was missing in this function since the subfolders wasn't allowed to be listed even if we had permisions over a parent folder.
Most of times testing and debugging this kind of operation is not trivial and requires a lot of time, thanks for the efforts! I'll make sure to publish into the next release and since it's not a breaking change and fixes a current behavior probably will be done on v0.3.2.
This was referenced Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #58.
Previously, calling listFiles on any document would always list the contents of the user-selected root in which the document resides. Now it will correctly list the children of subfolders.
Please review before merging, if you do decide that this is interesting, as I have never done anything with Kotlin until today.