Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subfolder contents listing and openDocumentFile API #63

Merged
merged 7 commits into from
Jul 1, 2022

Conversation

alexrintt
Copy link
Owner

@alexrintt alexrintt commented Jun 30, 2022

This pull request closes #62, #64 and indirectly starts #56.

This PR fixes the current behavior of listFiles and openDocumentFile API.

  • Now is possible to list contents of all subfolders of a granted Uri (Opened from openDocumentTree).
  • Now ACTION_VIEW intent builder through openDocumentFile API was fixed. So now it's possible to open any file of any kind in third party apps without needing specify the mime type.
  • Removed Android specific APIs:
    • DocumentFile.listFiles (Now it's only available globally).
    • buildDocumentUriUsingTree removed due high coupling with Android API (Android specific API that are not useful on any other platforms).
    • buildDocumentUri removed due high coupling with Android API (Android specific API that are not useful on any other platforms).
    • buildTreeDocumentUri removed due high coupling with Android API (Android specific API that are not useful on any other platforms).
  • getDocumentThumbnail now receives only the uri param instead of a rootUri and a documentId.

Huge thanks to @EternityForest who exposed a lot of relevant resources and contributed on #58 and #59.

@alexrintt alexrintt changed the title (#62) Apply fix and remove Android specific APIs Fix subfolder contents listing Jun 30, 2022
@alexrintt alexrintt added the stage:stable This issue/feature/resource seems to be stable enough to be considered released in the next version. label Jun 30, 2022
@alexrintt alexrintt changed the title Fix subfolder contents listing Fix subfolder contents listing and openDocumentFile API Jun 30, 2022
@alexrintt alexrintt marked this pull request as ready for review July 1, 2022 00:57
@alexrintt alexrintt merged commit 05b9d9f into master Jul 1, 2022
@alexrintt alexrintt deleted the feat/list-subfolder-contents branch July 1, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage:stable This issue/feature/resource seems to be stable enough to be considered released in the next version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subfolder content listing not working
1 participant