Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observability #54

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Observability #54

merged 10 commits into from
Aug 5, 2024

Conversation

jterapin
Copy link
Collaborator

@jterapin jterapin commented Jul 18, 2024

Description

Related PR: smithy-ruby
This PR incorporates expected changes from smithy-ruby to wrap the tracer around the RequestId Middleware.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jterapin jterapin changed the title [WIP] Incorporate tracers Observability Jul 24, 2024
@jterapin jterapin marked this pull request as ready for review July 24, 2024 21:36
Copy link
Collaborator

@mullermp mullermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but will change with comments I had on the other PR.

@jterapin jterapin merged commit 043bb58 into main Aug 5, 2024
9 checks passed
@jterapin jterapin deleted the implement_observability branch August 5, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants