-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Telemetry support #208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
...codegen/src/main/java/software/amazon/smithy/ruby/codegen/generators/TelemetryGenerator.java
Outdated
Show resolved
Hide resolved
...codegen/src/main/java/software/amazon/smithy/ruby/codegen/generators/TelemetryGenerator.java
Outdated
Show resolved
Hide resolved
...codegen/src/main/java/software/amazon/smithy/ruby/codegen/generators/TelemetryGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I generally approve, just needs a few clean ups.
Description
Observability is the extent to which a system's current state can be inferred from the data it emits. The data emitted is commonly referred to as telemetry. This PR will set up the groundwork for SDK instrumentation and current/future telemetry providers.
In addition, we will support OpenTelemetry as a telemetry provider.
Related PR: alextwoods/aws-sdk-ruby-v4#54
Changes
opentelemetry-sdk
gem for testing purposeshttp_method
(intended for span attribute testing)config_spec.rb
to include the new Config,telemetry_provider
.telemetry_spec.rb
to test Config and Client behaviors (includes OTel-related testings)telemetry_provider
SDK_ID
(if no SDK ID is present, we use Service Shape name)send_spec.rb
as adding telemetry support has changed how the tests are run* Add V4 support (separate PR in V4 repo)* Create child span on a middleware level* Update specs based on the child span + add more specs* Add documentationBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.