Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ not decoded as expected #3

Open
kornelski opened this issue Feb 24, 2020 · 0 comments
Open

+ not decoded as expected #3

kornelski opened this issue Feb 24, 2020 · 0 comments

Comments

@kornelski
Copy link

Unlike other percent-encoded parts of the URL, query strings also support + as a space character.

qstring doesn't substitute + for space, which makes it incompatible with web browsers submitting text using GET forms.
@bbx0 bbx0 mentioned this issue Apr 10, 2020
Merged
@alexliesenfeld alexliesenfeld mentioned this issue Dec 18, 2021
Closed
mwootten added a commit to mwootten/petscan_rs that referenced this issue Aug 28, 2023
@mwootten
Fix magnusmanske#132 by adjusting querystring processing
506150e 
The backend decodes querystrings with the qstring crate. However, that
decodes both a plus sign and a URL-encoded plus sign to exactly the
same thing, erasing the distinction between plus signs and spaces
(see algesten/qstring#3). This patch instead uses the underlying url
crate, which handles plus signs correctly.

This fix should be combined with magnusmanske#138, which fixes the frontend piece;
however, merging just this one would correct the saving in the backend.
@mwootten mwootten mentioned this issue Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kornelski