Fix #137 by removing needless deXSS function #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deXSS function escapes text so that it's safe to insert as raw HTML. However, its output gets passed into .val() and .text(), which directly manipulate the DOM and so don't require or support escaping; thus, the escaping breaks the queries. Remove deXSS where superfluous and replace its one non-superfluous use with safe DOM manipulation.
mwootten
added a commit
to mwootten/petscan_rs
that referenced
this pull request
Aug 28, 2023
The backend decodes querystrings with the qstring crate. However, that decodes both a plus sign and a URL-encoded plus sign to exactly the same thing, erasing the distinction between plus signs and spaces (see algesten/qstring#3). This patch instead uses the underlying url crate, which handles plus signs correctly. This fix should be combined with magnusmanske#138, which fixes the frontend piece; however, merging just this one would correct the saving in the backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deXSSfunction escapes text so that it's safe to insert as raw HTML. However, its output gets passed into.val()and.text(), which directly manipulate the DOM and so don't require or support escaping; thus, the escaping breaks the queries. RemovedeXSSwhere superfluous and replace its one non-superfluous use with safe DOM manipulation.