fix(recommend): update trending facets query props (RECO-1184) #1434
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41fe144:
|
| readonly maxRecommendations?: number; | ||
|
|
||
| /** | ||
| * Used for trending model |
There was a problem hiding this comment.
This doesn't describe what this param is? (Same for facetName and facetValue for trending items.)
| @@ -11,6 +11,5 @@ export * from './RecommendSearchOptions'; | |||
| export * from './RecommendationsQuery'; | |||
| export * from './RelatedProductsQuery'; | |||
| export * from './TrendingFacetsQuery'; | |||
| export * from './TrendingQuery'; | |||
There was a problem hiding this comment.
Any reasons to remove this export?
There was a problem hiding this comment.
removed the file completely and separated the trending query in 2 independent ones
There was a problem hiding this comment.
Yes but the type still exists: https://github.com/algolia/algoliasearch-client-javascript/pull/1434/files#diff-c2f0ecb57e8ccf256bade6bed628a6494a8758ed3a4756877bcccf1b3db25d69R16-R18
I'm fine removing the export as long as it's a conscious decision.
There was a problem hiding this comment.
but here is only a local type as it's only used (and needed) in getRecommendations, so there's no need to export it.
There was a problem hiding this comment.
I was more hinting the fact that it could be a breaking change now that it's not exported anymore. I think it's OK, but we should acknowledge it.
Update trendingFacets query props and refactor types