-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(recommend): update trending facets query props (RECO-1184) #1434
Merged
+66
−55
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,21 @@ | ||
import { TrendingQuery } from './TrendingQuery'; | ||
export type TrendingFacetsQuery = { | ||
/** | ||
* The name of the target index. | ||
*/ | ||
readonly indexName: string; | ||
|
||
export type TrendingFacetsQuery = Omit< | ||
TrendingQuery, | ||
'model' | 'facetValue' | 'fallbackParameters' | 'queryParameters' | ||
>; | ||
/** | ||
* Threshold for the recommendations confidence score (between 0 and 100). Only recommendations with a greater score are returned. | ||
*/ | ||
readonly threshold?: number; | ||
|
||
/** | ||
* How many recommendations to retrieve. | ||
*/ | ||
readonly maxRecommendations?: number; | ||
|
||
/** | ||
* The facet attribute to get recommendations for. | ||
*/ | ||
readonly facetName: string; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,40 @@ | ||
import { TrendingQuery } from './TrendingQuery'; | ||
import { RecommendSearchOptions } from '@algolia/recommend'; | ||
|
||
export type TrendingItemsQuery = Omit<TrendingQuery, 'model'>; | ||
export type TrendingItemsQuery = { | ||
/** | ||
* The name of the target index. | ||
*/ | ||
readonly indexName: string; | ||
|
||
/** | ||
* Threshold for the recommendations confidence score (between 0 and 100). Only recommendations with a greater score are returned. | ||
*/ | ||
readonly threshold?: number; | ||
|
||
/** | ||
* How many recommendations to retrieve. | ||
*/ | ||
readonly maxRecommendations?: number; | ||
|
||
/** | ||
* List of [search parameters](https://www.algolia.com/doc/api-reference/search-api-parameters/) to send. | ||
*/ | ||
readonly queryParameters?: RecommendSearchOptions; | ||
|
||
/** | ||
* List of [search parameters](https://www.algolia.com/doc/api-reference/search-api-parameters/) to send. | ||
* | ||
* Additional filters to use as fallback when there aren’t enough recommendations. | ||
*/ | ||
readonly fallbackParameters?: RecommendSearchOptions; | ||
|
||
/** | ||
* The facet attribute to get recommendations for. | ||
*/ | ||
readonly facetName?: string; | ||
|
||
/** | ||
* The value of the target facet. | ||
*/ | ||
readonly facetValue?: string; | ||
}; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reasons to remove this export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the file completely and separated the trending query in 2 independent ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but the type still exists: https://github.com/algolia/algoliasearch-client-javascript/pull/1434/files#diff-c2f0ecb57e8ccf256bade6bed628a6494a8758ed3a4756877bcccf1b3db25d69R16-R18
I'm fine removing the export as long as it's a conscious decision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but here is only a local type as it's only used (and needed) in
getRecommendations
, so there's no need to export it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was more hinting the fact that it could be a breaking change now that it's not exported anymore. I think it's OK, but we should acknowledge it.