Merge pull request #94 from algolia/fix/92

Fix #92 parameters that can be set in the dashboard shouldn't have defaults
algolia · Jun 3, 2015 · 171eb56 · 171eb56
2 parents 795f9ca + dee2384
commit 171eb56
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,6 +1,8 @@
 CHANGELOG
 
 UNRELEASED
+  * FIX : #92 Parameters that can be set in the dashboard shouldn't have
+  defaults
   * FEATURE : Ability to modify any parameter of the state easily (#76 #84)
   * FEATURE : #69 Ability to know if a facet is refined, whatever the value
 

diff --git a/src/SearchParameters/index.js b/src/SearchParameters/index.js
@@ -36,6 +36,7 @@ var SearchParameters = function( newParameters ) {
    * @member {string}
    */
   this.query = params.query || "";
+
   //Facets
   /**
    * All the facets that will be requested to the server
@@ -58,16 +59,16 @@ var SearchParameters = function( newParameters ) {
    * @member {Object.<string, OperatorList>}
    */
   this.numericRefinements = params.numericRefinements || {};
+
   //Misc. parameters
   /** @member {number} */
-  this.hitsPerPage = params.hitsPerPage || 20;
+  this.hitsPerPage = params.hitsPerPage;
   /**
    * @member {number}
    **/
-  this.maxValuesPerFacet = params.maxValuesPerFacet || 10;
+  this.maxValuesPerFacet = params.maxValuesPerFacet;
   /** @member {number} */
   this.page = params.page || 0;
-
   /**
    * Possible values : prefixAll, prefixLast, prefixNone
    * @see https://www.algolia.com/doc#queryType