Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Do not set default values that are computed in the API server #92

Closed
maxiloc opened this issue Jun 3, 2015 · 2 comments
Closed

Do not set default values that are computed in the API server #92

maxiloc opened this issue Jun 3, 2015 · 2 comments
Assignees
@bobylito
Labels
Type: Bug
Milestone
2.1.0

Comments

@maxiloc
Copy link
Contributor

maxiloc commented Jun 3, 2015

For example hitsPerPage and maxValuesPerFacet
@vvo vvo changed the title We don't want to set default values for parameters that can be set in the Dashboard Do not set default values that are computed in the API server Jun 3, 2015
@vvo
Copy link
Contributor

vvo commented Jun 3, 2015

=> All default values are computed by the API so yes no need to have them in the helper, it can break.

On a side note we had some tests like

var hitsPerPage = params.hitsPerPage || 20;

Which means that if the user pass hitsPerPage = 0 (yes, doesn't make sense but could make sense in another param) then it will default to 20.

(only adding this because it's a common pitfall of boolean operators usage in JS)

@bobylito
Copy link
Contributor

bobylito commented Jun 3, 2015

ok will update that for dashboard/engine parameters.

@bobylito bobylito added this to the 2.1.0 milestone Jun 3, 2015
@bobylito bobylito self-assigned this Jun 3, 2015
bobylito pushed a commit that referenced this issue Jun 3, 2015
Fix #92 parameters that can be set in the dashboard shouldn't have de…
7e46daf 
…faults
bobylito added a commit that referenced this issue Jun 3, 2015
@bobylito
Merge pull request #94 from algolia/fix/92
171eb56 
Fix #92 parameters that can be set in the dashboard shouldn't have defaults
bobylito pushed a commit that referenced this issue Jun 15, 2015
2.1.0 - 2015-06-15
586a07e 
  * FIX : #29 Avoid callback for outdated queries
  * FIX : #64 Sum up the processing time of all queries
  * FIX : #92 Parameters that can be set in the dashboard shouldn't have defaults
  * FIX : #62 Make sure disctinct is set to false when it's not possible to use distinct in Algolia
  * FEATURE : #91 Support for tags (with support for the raw format #98)
  * FEATURE : #70 Ability to get all refined values : helper.getRefinements( facetname )
  * FEATURE : #51 multiple filters for a single conjunctive facet (tests)
  * FEATURE : Ability to modify any parameter of the state easily (#76 #84 #12)
  * FEATURE : #69 Ability to know if a facet is refined, whatever the value
  * FEATURE : #86 Expose SearchParameters, AlgoliaSearchHelper, SearchResults to users directly in the builds
  * FEATURE : #25 let the user do a clearRefinement with a function as a filter
  * REFACTORING : SearchParameters is immutable (#14)
  * REFACTORING : Ensure SearchParameters is totally frozen (#14)
  * LIB : Update lodash version to 3.9.x
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
Fix algolia/algoliasearch-helper-js#92 parameters that can be set in …
4d907e4 
…the dashboard shouldn't have defaults
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
@bobylito
Merge pull request algolia/algoliasearch-helper-js#94 from algolia/fi…
43aa108 
…x/92

Fix algolia/algoliasearch-helper-js#92 parameters that can be set in the dashboard shouldn't have defaults
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
2.1.0 - 2015-06-15
9990a55 
  * FIX : algolia/algoliasearch-helper-js#29 Avoid callback for outdated queries
  * FIX : algolia/algoliasearch-helper-js#64 Sum up the processing time of all queries
  * FIX : algolia/algoliasearch-helper-js#92 Parameters that can be set in the dashboard shouldn't have defaults
  * FIX : algolia/algoliasearch-helper-js#62 Make sure disctinct is set to false when it's not possible to use distinct in Algolia
  * FEATURE : algolia/algoliasearch-helper-js#91 Support for tags (with support for the raw format #98)
  * FEATURE : algolia/algoliasearch-helper-js#70 Ability to get all refined values : helper.getRefinements( facetname )
  * FEATURE : algolia/algoliasearch-helper-js#51 multiple filters for a single conjunctive facet (tests)
  * FEATURE : Ability to modify any parameter of the state easily (algolia/algoliasearch-helper-js#76 #84 #12)
  * FEATURE : algolia/algoliasearch-helper-js#69 Ability to know if a facet is refined, whatever the value
  * FEATURE : algolia/algoliasearch-helper-js#86 Expose SearchParameters, AlgoliaSearchHelper, SearchResults to users directly in the builds
  * FEATURE : algolia/algoliasearch-helper-js#25 let the user do a clearRefinement with a function as a filter
  * REFACTORING : SearchParameters is immutable (algolia/algoliasearch-helper-js#14)
  * REFACTORING : Ensure SearchParameters is totally frozen (algolia/algoliasearch-helper-js#14)
  * LIB : Update lodash version to 3.9.x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobylito bobylito

Labels
Type: Bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@vvo @bobylito @maxiloc