Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Conjunctive facets aren't stored in a array #51

Closed
Jerska opened this issue Apr 14, 2015 · 9 comments
Closed

Conjunctive facets aren't stored in a array #51

Jerska opened this issue Apr 14, 2015 · 9 comments
Assignees
@bobylito
Labels
Type: Bug

Comments

@Jerska
Copy link
Member

Jerska commented Apr 14, 2015

It works fine except when facetting an array attribute.
@bobylito
Copy link
Contributor

Thanks! :)

@bobylito bobylito mentioned this issue May 12, 2015
Closed
@redox redox added the major label May 14, 2015
@redox
Copy link
Contributor

redox commented May 14, 2015

This one is done, right?

@Jerska
Copy link
Member Author

Jerska commented May 15, 2015

We have to release a new version for this, or we will break a lot of existing apps.

@bobylito
Copy link
Contributor

bobylito commented Jun 2, 2015

Just to be sure @jerskouille, what was the use case?

@Jerska
Copy link
Member Author

Jerska commented Jun 2, 2015

Conjunctive facetting with ANDs : tags:cat,tags:food. Isn't this working now though?

@bobylito
Copy link
Contributor

bobylito commented Jun 2, 2015

Let's make a test for that ;)

@bobylito bobylito self-assigned this Jun 3, 2015
@bobylito
Copy link
Contributor

bobylito commented Jun 3, 2015

Just to be clear, we need three things here :

  • multiple parameters for single conjunctive facet stored in our SearchParameters
  • multiple parameters sent as the request
  • the facet values back in the response

@bobylito
Copy link
Contributor

bobylito commented Jun 3, 2015

@redox @jerskouille tests are in a PR #93 ;)

@bobylito
Copy link
Contributor

bobylito commented Jun 4, 2015

Fixed with #93

@bobylito bobylito closed this as completed Jun 4, 2015
bobylito pushed a commit that referenced this issue Jun 15, 2015
2.1.0 - 2015-06-15
586a07e 
  * FIX : #29 Avoid callback for outdated queries
  * FIX : #64 Sum up the processing time of all queries
  * FIX : #92 Parameters that can be set in the dashboard shouldn't have defaults
  * FIX : #62 Make sure disctinct is set to false when it's not possible to use distinct in Algolia
  * FEATURE : #91 Support for tags (with support for the raw format #98)
  * FEATURE : #70 Ability to get all refined values : helper.getRefinements( facetname )
  * FEATURE : #51 multiple filters for a single conjunctive facet (tests)
  * FEATURE : Ability to modify any parameter of the state easily (#76 #84 #12)
  * FEATURE : #69 Ability to know if a facet is refined, whatever the value
  * FEATURE : #86 Expose SearchParameters, AlgoliaSearchHelper, SearchResults to users directly in the builds
  * FEATURE : #25 let the user do a clearRefinement with a function as a filter
  * REFACTORING : SearchParameters is immutable (#14)
  * REFACTORING : Ensure SearchParameters is totally frozen (#14)
  * LIB : Update lodash version to 3.9.x
dhayab pushed a commit to algolia/instantsearch that referenced this issue Jul 10, 2023
2.1.0 - 2015-06-15
9990a55 
  * FIX : algolia/algoliasearch-helper-js#29 Avoid callback for outdated queries
  * FIX : algolia/algoliasearch-helper-js#64 Sum up the processing time of all queries
  * FIX : algolia/algoliasearch-helper-js#92 Parameters that can be set in the dashboard shouldn't have defaults
  * FIX : algolia/algoliasearch-helper-js#62 Make sure disctinct is set to false when it's not possible to use distinct in Algolia
  * FEATURE : algolia/algoliasearch-helper-js#91 Support for tags (with support for the raw format #98)
  * FEATURE : algolia/algoliasearch-helper-js#70 Ability to get all refined values : helper.getRefinements( facetname )
  * FEATURE : algolia/algoliasearch-helper-js#51 multiple filters for a single conjunctive facet (tests)
  * FEATURE : Ability to modify any parameter of the state easily (algolia/algoliasearch-helper-js#76 #84 #12)
  * FEATURE : algolia/algoliasearch-helper-js#69 Ability to know if a facet is refined, whatever the value
  * FEATURE : algolia/algoliasearch-helper-js#86 Expose SearchParameters, AlgoliaSearchHelper, SearchResults to users directly in the builds
  * FEATURE : algolia/algoliasearch-helper-js#25 let the user do a clearRefinement with a function as a filter
  * REFACTORING : SearchParameters is immutable (algolia/algoliasearch-helper-js#14)
  * REFACTORING : Ensure SearchParameters is totally frozen (algolia/algoliasearch-helper-js#14)
  * LIB : Update lodash version to 3.9.x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobylito bobylito

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@redox @bobylito @Jerska