fix(java): solve oneOf using a custom generator APIC-300 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
reviewed
Feb 8, 2022
generators/src/main/java/com/algolia/codegen/AlgoliaJavaGenerator.java
Outdated
Show resolved
Hide resolved
...lgoliasearch-client-java-2/algoliasearch-core/com/algolia/model/search/BaseSearchParams.java
Outdated
Show resolved
Hide resolved
|
Can you use the Same for #102 |
millotp
changed the title
millotp
force-pushed
the
fix/solve-one-of
branch
3 times, most recently
from
8dbfaf6
to
1f79eda
Compare
|
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 06a6efd 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6221dc13a2922b0008bd736f |
millotp
force-pushed
the
fix/solve-one-of
branch
from
eab6a7b
to
c6fdd47
Compare
shortcuts
reviewed
Mar 3, 2022
shortcuts
approved these changes
Mar 4, 2022
|
Good idea, I created a ticket for it. |
This was referenced Mar 22, 2022
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: APIC-300
Because the templating is not enough to generate oneOf for java and maybe other clients, this PR creates a custom generator for java using the command:
And modified it to add the
setUseOneOfInterfaces(true)(not accessible otherwise).Also experimented with adding
additionalPropertiesfrom Java itself which mean we can add any object we want, like servers.An issue with
openapi-generator-clibreaks custom generator and forces us to use the jar directly but this is getting fixed.PRs
Follow the stack !
Changes included:
searchpackage🧪 Test