Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(php): Remove header handling in clients #128

Merged
merged 9 commits into from
Feb 10, 2022

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Feb 9, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-302

Changes included:

  • Removed unused variables in the clients' methods
  • User-Agent assignement

🧪 Test

CI

@damcou damcou marked this pull request as ready for review February 9, 2022 16:39
@damcou damcou requested a review from millotp February 9, 2022 16:40
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup ! Btw $config in ApiWrapper.php is unused.

@damcou damcou requested a review from millotp February 10, 2022 11:03
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants