Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php): Remove header handling in clients #128

Merged
merged 9 commits into from
Feb 10, 2022
Merged

fix(php): Remove header handling in clients #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
673bfa2
fix(php): remove header handling in clients
damcou Feb 9, 2022
4efef96
Merge branch 'main' into feat/APIC-302/php-headers-management
damcou Feb 9, 2022
e159bf1
fix: user-agent setting
damcou Feb 9, 2022
5e998b0
Merge branch 'main' into feat/APIC-302/php-headers-management
damcou Feb 9, 2022
e80cf6a
fix: changes after review
damcou Feb 10, 2022
6737c08
Merge branch 'main' into feat/APIC-302/php-headers-management
damcou Feb 10, 2022
521fc2a
fix: change the template
damcou Feb 10, 2022
a5e4057
Merge branch 'feat/APIC-302/php-headers-management' of https://github…
damcou Feb 10, 2022
72fcf78
Merge branch 'main' into feat/APIC-302/php-headers-management
damcou Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/algoliasearch-client-php/lib/Algolia.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

final class Algolia
{
const VERSION = '1.0.0';
const VERSION = '4.0.0';

/**
* Holds an instance of the simple cache repository (PSR-16).
Expand Down
103 changes: 8 additions & 95 deletions clients/algoliasearch-client-php/lib/Api/AbtestingApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,30 +109,13 @@ public function addABTests($addABTestsRequest)

$resourcePath = '/2/abtests';
$queryParams = [];
$headerParams = [];
$httpBody = [];

$headers = [];
$headers['Accept'] = 'application/json';
$headers['Content-Type'] = 'application/json';
if (isset($addABTestsRequest)) {
$httpBody = $addABTestsRequest;
}

$defaultHeaders = [];
if ($this->config->getUserAgent()) {
$defaultHeaders['User-Agent'] = $this->config->getUserAgent();
}

$headers = array_merge(
$defaultHeaders,
$headerParams,
$headers
);

$query = \GuzzleHttp\Psr7\Query::build($queryParams);

return $this->sendRequest('POST', $resourcePath, $query, $httpBody);
return $this->sendRequest('POST', $resourcePath, $queryParams, $httpBody);
}
/**
* Operation deleteABTest
Expand All @@ -157,7 +140,6 @@ public function deleteABTest($id)

$resourcePath = '/2/abtests/{id}';
$queryParams = [];
$headerParams = [];
$httpBody = [];
// path params
if ($id !== null) {
Expand All @@ -168,24 +150,7 @@ public function deleteABTest($id)
);
}

$headers = [];
$headers['Accept'] = 'application/json';
$headers['Content-Type'] = 'application/json';

$defaultHeaders = [];
if ($this->config->getUserAgent()) {
$defaultHeaders['User-Agent'] = $this->config->getUserAgent();
}

$headers = array_merge(
$defaultHeaders,
$headerParams,
$headers
);

$query = \GuzzleHttp\Psr7\Query::build($queryParams);

return $this->sendRequest('DELETE', $resourcePath, $query, $httpBody);
return $this->sendRequest('DELETE', $resourcePath, $queryParams, $httpBody);
}
/**
* Operation getABTest
Expand All @@ -210,7 +175,6 @@ public function getABTest($id)

$resourcePath = '/2/abtests/{id}';
$queryParams = [];
$headerParams = [];
$httpBody = [];
// path params
if ($id !== null) {
Expand All @@ -221,24 +185,7 @@ public function getABTest($id)
);
}

$headers = [];
$headers['Accept'] = 'application/json';
$headers['Content-Type'] = 'application/json';

$defaultHeaders = [];
if ($this->config->getUserAgent()) {
$defaultHeaders['User-Agent'] = $this->config->getUserAgent();
}

$headers = array_merge(
$defaultHeaders,
$headerParams,
$headers
);

$query = \GuzzleHttp\Psr7\Query::build($queryParams);

return $this->sendRequest('GET', $resourcePath, $query, $httpBody);
return $this->sendRequest('GET', $resourcePath, $queryParams, $httpBody);
}
/**
* Operation listABTests
Expand All @@ -257,7 +204,6 @@ public function listABTests($offset = 0, $limit = 10)
{
$resourcePath = '/2/abtests';
$queryParams = [];
$headerParams = [];
$httpBody = [];

if ($offset !== null) {
Expand All @@ -280,24 +226,7 @@ public function listABTests($offset = 0, $limit = 10)
}
}

$headers = [];
$headers['Accept'] = 'application/json';
$headers['Content-Type'] = 'application/json';

$defaultHeaders = [];
if ($this->config->getUserAgent()) {
$defaultHeaders['User-Agent'] = $this->config->getUserAgent();
}

$headers = array_merge(
$defaultHeaders,
$headerParams,
$headers
);

$query = \GuzzleHttp\Psr7\Query::build($queryParams);

return $this->sendRequest('GET', $resourcePath, $query, $httpBody);
return $this->sendRequest('GET', $resourcePath, $queryParams, $httpBody);
}
/**
* Operation stopABTest
Expand All @@ -322,7 +251,6 @@ public function stopABTest($id)

$resourcePath = '/2/abtests/{id}/stop';
$queryParams = [];
$headerParams = [];
$httpBody = [];
// path params
if ($id !== null) {
Expand All @@ -333,28 +261,13 @@ public function stopABTest($id)
);
}

$headers = [];
$headers['Accept'] = 'application/json';
$headers['Content-Type'] = 'application/json';

$defaultHeaders = [];
if ($this->config->getUserAgent()) {
$defaultHeaders['User-Agent'] = $this->config->getUserAgent();
}

$headers = array_merge(
$defaultHeaders,
$headerParams,
$headers
);

$query = \GuzzleHttp\Psr7\Query::build($queryParams);

return $this->sendRequest('POST', $resourcePath, $query, $httpBody);
return $this->sendRequest('POST', $resourcePath, $queryParams, $httpBody);
}

private function sendRequest($method, $resourcePath, $query, $httpBody)
private function sendRequest($method, $resourcePath, $queryParams, $httpBody)
{
$query = \GuzzleHttp\Psr7\Query::build($queryParams);

if ($method === 'GET') {
$request = $this->api->read(
$method,
Expand Down
Loading