Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): cache common files #427

Merged
merged 7 commits into from
Apr 27, 2022
Merged

fix(java): cache common files #427

merged 7 commits into from
Apr 27, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Apr 25, 2022

🧭 What and Why

Some common generated files were not cached properly and not pushed to main.

Changes included:

  • Include gradle in cache

🧪 Test

See the generated code comment

@millotp millotp requested a review from a team April 25, 2022 16:48
@millotp millotp self-assigned this Apr 25, 2022
@millotp millotp requested review from eunjae-lee and damcou and removed request for a team April 25, 2022 16:48
@netlify
Copy link

netlify bot commented Apr 25, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit e5a084f
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/626905c9c4e16f0008784f66

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 25, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts
Copy link
Member

Is no code gen expected?

@millotp millotp marked this pull request as draft April 26, 2022 07:27
@millotp millotp force-pushed the fix/java-common branch 2 times, most recently from 42761a5 to 1373416 Compare April 26, 2022 12:45
damcou
damcou previously approved these changes Apr 26, 2022
@millotp millotp marked this pull request as ready for review April 26, 2022 18:40
@millotp millotp requested a review from damcou April 26, 2022 18:41
@millotp millotp marked this pull request as draft April 26, 2022 18:41
@millotp millotp marked this pull request as ready for review April 27, 2022 08:50
@millotp
Copy link
Collaborator Author

millotp commented Apr 27, 2022

This PR is very late so the file got generated on main in the mean time and it's hard to verify this works, but I will do further testing once it's merged

eunjae-lee
eunjae-lee previously approved these changes Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants