-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(java): cache common files #427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
requested review from
eunjae-lee and
damcou
and removed request for
a team
April 25, 2022 16:48
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Is no code gen expected? |
millotp
force-pushed
the
fix/java-common
branch
2 times, most recently
from
April 26, 2022 12:45
42761a5
to
1373416
Compare
damcou
previously approved these changes
Apr 26, 2022
millotp
force-pushed
the
fix/java-common
branch
from
April 26, 2022 18:26
1373416
to
ae3c127
Compare
This PR is very late so the file got generated on main in the mean time and it's hard to verify this works, but I will do further testing once it's merged |
eunjae-lee
previously approved these changes
Apr 27, 2022
eunjae-lee
approved these changes
Apr 27, 2022
This was referenced Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Some common generated files were not cached properly and not pushed to main.
Changes included:
🧪 Test
See the generated code comment