fix(ci): rm deleted files #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Apr 26, 2022
| @@ -0,0 +1,234 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
why did you gen those files by hand ?
They should be generated by #427 but there is an issue
There was a problem hiding this comment.
It has been pending for 3 PRs so I've pushed them trying to find where it was failing, but I've then realized it was in the composite cache path
millotp
approved these changes
Apr 26, 2022
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Apr 26, 2022
algolia/api-clients-automation#432 Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Apr 26, 2022
algolia/api-clients-automation#432 Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Apr 26, 2022
algolia/api-clients-automation#432 Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
This was referenced Apr 28, 2022
This was referenced May 24, 2022
This was referenced May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Follow up of #408 :(
As seen in #413, the CI still does not push deleted files.
Explanations:
TLDR: push deleted files.
🧪 Test
CI