-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(php): Add tests for query params #475
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :D
CI failing will actually be fixed in #482 |
22c18b1
to
1ca1d34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !
It's surprising that it doesn't change anything in the java CTS.
I guess the next step is to add header
to the CTS !
if ({{paramName}} !== undefined) { | ||
headers['{{baseName}}'] = {{paramName}}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is equivalent to before, is this needed ?
You should also add toString()
at the end just in case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes because now the param can be added both in the headers and the query params
Looks like something is wrong with the CI checking diff, you forgot to generate the Java CTS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect :)
🧭 What and Why
🎟 JIRA Ticket: APIC-456
Changes included:
RequestOptionsFactory
class to make it compatible with the automationX-Algolia-User-ID
in the tests, since it should be a header, regarding the API doc : https://www.algolia.com/doc/rest-api/search/#assign-or-move-userid🧪 Test
yarn docker cts run php