fix(javascript): move logic to custom gens #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
fix/javascript-template
branch
from
8086207
to
dbe8058
Compare
eunjae-lee
previously approved these changes
May 10, 2022
millotp
reviewed
May 10, 2022
generators/src/main/java/com/algolia/codegen/AlgoliaJavascriptGenerator.java
Outdated
Show resolved
Hide resolved
millotp
reviewed
May 10, 2022
millotp
reviewed
May 10, 2022
millotp
approved these changes
May 10, 2022
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-479
Changes included:
This PR aims at removing the (ugly) logic I had introduced in the template when we did not had with custom gens.
Output is the same, but at least it's now mostly readable.
Should unblock #475 too
🧪 Test
CI :D