fix(specs): fix missing params and types #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
shortcuts
force-pushed
the
fix/specs-params
branch
from
1e7152e
to
d66ca98
Compare
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
fix/specs-params
branch
from
d66ca98
to
48cd2a1
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
shortcuts
force-pushed
the
fix/specs-params
branch
from
9e6535a
to
7a2a716
Compare
millotp
reviewed
Jul 4, 2022
clients/algoliasearch-client-php/lib/Model/Search/SchemasQuery.php
Outdated
Show resolved
Hide resolved
| @@ -58,5 +58,361 @@ | |||
| "forwardToReplicas": "true" | |||
| } | |||
| } | |||
| }, | |||
millotp
reviewed
Jul 4, 2022
| - $ref: '#/searchFiltersNestedArrayString' | ||
| x-categories: | ||
| - Advanced | ||
| - $ref: '#/listOfSearchFilters' |
There was a problem hiding this comment.
it's too bad that all of those filters are the same type but different object, it means they are not compatible in java just because we want a different description
There was a problem hiding this comment.
Yup indeed, but there's also a benefit of doing this is that you call the constructor with the same name of the object you are trying to build, while with a single object it would be something like SearchFilters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-553
Changes included:
There's a lot of spec changes that has been implemented on some clients but not been documented. In this PR, I've took a look at a few of them to find some fixes to apply, but also find some myself.
I'll split the PR if it becomes too big
filterswrongly typedreRankingApplyFilteris nullableinsideBoundingBoxcan be a stringgetAbTestmissing response fieldConsequencePromoteallow group promotecustomNormalizationinindexSettingshasPendingMappingsresponse is incorrectConsequenceQueryallOf definition is wrongqueryoverlap withsearchParams, which makes type wrong (for at least Java and JavaScript)consequenceshould be optionalabtestinghas its own client🧪 Test
CI :D