Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Configure></Configure> should update the searchState inside a configure: {} #1863

Closed
vvo opened this issue Jan 18, 2017 · 6 comments
Closed
Assignees

Comments

@vvo
Copy link
Contributor

vvo commented Jan 18, 2017

Ref: https://twitter.com/zachcodes/status/821484313325740032

@zackify
Copy link

zackify commented Jan 18, 2017

Oops, sorry. Just assumed there couldn't have been an issue already, my bad.

@zackify
Copy link

zackify commented Jan 18, 2017

Want to point me in the right direction and I can try my hand at this for you?

@vvo
Copy link
Contributor Author

vvo commented Jan 18, 2017

In fact I think we are missing a bit of architecture needs to make this happen but you could give a try at:

Ultimately we may need a way to be able to enhance the search state as soon as possible without having to call refine manually immediately because that could lead to weird behaviors.

@zackify
Copy link

zackify commented Jan 18, 2017

@vvo I'll have to get the repo running, but in regards to point 3, on componentDidMount and anytime componentWillReceiveProps has different props, we could call refine.

@mthuret mthuret self-assigned this Feb 1, 2017
@vvo vvo closed this as completed in 0971330 Feb 6, 2017
@zackify
Copy link

zackify commented Feb 6, 2017

Awesome work! When will this be pushed to npm?

vvo pushed a commit that referenced this issue Feb 6, 2017
<a name="3.0.0"></a>
# [3.0.0](v2.2.5...v3.0.0) (2017-02-06)

### Bug Fixes

* ***List:** disable shortcuts in *List SearchBoxes (#1921) ([51a76ae](51a76ae)), closes [#1920](#1920)
* **Configure:** add configure parameters in search state (#1935) ([0971330](0971330)), closes [#1863](#1863)
* **Hits:** limit the hitComponent to be only a function (#1912) ([b3c9578](b3c9578))
* **Pagination:** fix and indicate when pagination is disabled ([5f20199](5f20199)), closes [#1938](#1938)
* **StarRating:** usage with filters (#1933) ([667e9d5](667e9d5))
* **withSearchBox:** keep displaying searchBox when no items found (#1930) ([30de4cd](30de4cd))

### Features

* **MultiRange:** indicate if a range has no refinements (#1926) ([80b6450](80b6450))
* **panel:** add a panel widget (#1889) ([594e1a1](594e1a1))
* **starRating:** indicate when any refinement has no effect ([c547ae5](c547ae5))
* **widgets:** default design for disabled states (#1929) ([31f010b](31f010b))
@vvo
Copy link
Contributor Author

vvo commented Feb 6, 2017

It has been pushed to npm (3.0.0): https://discourse.algolia.com/t/react-instantsearch-3-0-0/503/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants