fix(Hits): limit the hitComponent to be only a function #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobylito
approved these changes
Jan 26, 2017
|
@mikaa123 There are some failing tests, can you have a look? |
mikaa123
force-pushed
the
fix-hits-props
branch
from
c9c630a to
a7d1559
Compare
vvo
pushed a commit
that referenced
this pull request
Feb 6, 2017
<a name="3.0.0"></a> # [3.0.0](v2.2.5...v3.0.0) (2017-02-06) ### Bug Fixes * ***List:** disable shortcuts in *List SearchBoxes (#1921) ([51a76ae](51a76ae)), closes [#1920](#1920) * **Configure:** add configure parameters in search state (#1935) ([0971330](0971330)), closes [#1863](#1863) * **Hits:** limit the hitComponent to be only a function (#1912) ([b3c9578](b3c9578)) * **Pagination:** fix and indicate when pagination is disabled ([5f20199](5f20199)), closes [#1938](#1938) * **StarRating:** usage with filters (#1933) ([667e9d5](667e9d5)) * **withSearchBox:** keep displaying searchBox when no items found (#1930) ([30de4cd](30de4cd)) ### Features * **MultiRange:** indicate if a range has no refinements (#1926) ([80b6450](80b6450)) * **panel:** add a panel widget (#1889) ([594e1a1](594e1a1)) * **starRating:** indicate when any refinement has no effect ([c547ae5](c547ae5)) * **widgets:** default design for disabled states (#1929) ([31f010b](31f010b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What project are you opening a pull request for?
Summary
This merge request limits the
hitComponentprop of<Hits>to be only a function. It keeps the API simple, and will now print a warning if the user pass a string.Result
Passing a string to
hitComponentnow makes React complain about it.