-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing vue-server-renderer/basic module on build #5394
Comments
Hi @Jaimeloeuf, could you show how you are using and importing Vue InstantSearch? could you make this in a GitHub repo or a sandbox? |
I'm using Webpack Encore and I have this issue too. It's blocking us from using The error message is coming from Encore and/or the friendly-errors-webpack-plugin. EDIT: my bad, the error message in OP is not the same I faced: So the error is coming from vue-instantsearch, or webpack, or friendly-errors-webpack-plugin. EDIT2: Okay, so I disabled the friendly-errors-webpack-plugin and I don't have the issue anymore. The project is building correctly and I don't have any runtime errors (but I don't use SSR). Encore
.addEntry('...')
// ...
const config = Encore.getWebpackConfig();
// Exclude FriendlyErrorsWebpackPlugin, workaround for https://github.com/algolia/instantsearch/issues/5394
config.plugins = config.plugins.filter((plugin) => {
return plugin.constructor.name !== 'FriendlyErrorsWebpackPlugin';
});
module.exports = config; @Jaimeloeuf (sacré pseudo 🤣) can you confirm you are using:
Thanks! |
I feel like that's a bug in those plugins, the dependency is only used if you actually use it, which is why we use |
Yup, just ran into this issue myself; the workaround does not work though,
Adding the unused library fixes the issue:
|
Thanks for reporting @tristanbes. If you are not using Server side rendering, it's best to not include the library, or alias it to an empty module (especially for client-side). We do a conditional |
I'm seeing a similar issue with the same
The resulting app bundle still seems to work, but it's just showing this warning. I've setup a minimal repo with Laravel Mix (same as my production setup) if this helps: https://github.com/saltymouse/algolia-vue-instantsearch-module-warning |
+1 on this :( |
@sunscreem maybe you can help us by telling what building tool you use, your node version, etc ... instead of a +1 |
@Kocal apologies - I thought you had all the information you needed above. I've solved this by doing a Happy to give you all the details you need to debug this. Can you let me know what would help? |
a git repository with a reproduction. This should be something related to the setup of your tools, and not related to InstantSearch itself, we have done some guarding to make sure that webpack / parcel / rollup treats it as runtime dependency |
Hi, sorry to hijack this conversation but i think this could be helpful:
In a Laravel Mix configuration file you can do so like this:
|
Also having the same issue with webpack and could not solve it with |
I had the same issues using the latest |
Status update: We had the workaround from #5394 (comment) in place and I just tried removing it to see if the error persists and can report it's gone for
|
Thanks, there indeed haven't really been any reports of this in a while, I assume bundlers have caught up? Let's close for now. |
Bug 🐞
What is the current behavior?
Currently after building my app, the vue cli shows the following error:
Does this happen only in specific situations? And What is the version you are using?
This only happened right after I upgraded dependencies for algolia related items:
The text was updated successfully, but these errors were encountered: