-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Encore 1.0 dev-server failed #893
Comments
In the new version of |
Thanks I see it. And removed accordingly. |
Thanks @mbabker for helping out! However, I DO think there is a problem in Encore (this upgrade was a late addition). Encore sets a |
version 1.0.1 is now out - please let me know if you have any additional issues :). |
It is better thanks @weaverryan Maybe due to
The I'll investigate more with removing Ckeditor5 package to test if it is related and came back. But it start better than yesterday 😄 |
Sadly, I retry compiling with and without @CKEditor5 and I can't use my project on Dev env because I wait for long time but nothing appears. I try to tweak webpack-dev-server options without success. |
Hi, I'm also facing issues with the dev-server: Like @kl3sk, the file |
I'll reopen this. I believe it's caused by |
This PR was merged into the main branch. Discussion ---------- Working around missing manifest.json bug This fixes the 2nd part of #893 - #893 (comment) On Webpack 5, there is some miscommunication between the CleanWebpackPlugin and the WebpackManifestPlugin when using `dev-server`. The `WebpackManifestPlugin` *does* emit the physical `manifest.json` file, but CleanWebpackPlugin then deletes it. CleanWebpackPlugin should just remove files *before* we start, and not delete anything that's emitted. I'm not sure which plugin has the bug. But, the work around is quite clean. Commits ------- a4a6665 Working around missing manifest.json bug
Fixed again - try 1.0.2 :) |
I can confirm it's working, thanks! |
Sorry for the late answer, it works flawlessly ! Thanks again @weaverryan. But @ckeditor fail as well, this is not relataed directly with Encore I know, is someone have same troubles, I open an issue ckeditor/ckeditor5#8950. Happy packing 😄 ! |
Hello,
I try updating my project with the new
Encore 1.0
, but after trying to update my config I ran on a fail buildHere is the error when I start
npm run dev-server
Here is the npm log:
I try to remove
node_module
and npm install with the same error.But
npm run build
works with the same configuration.Thanks
The text was updated successfully, but these errors were encountered: