test(pagination): add common test suite #5836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f61c43f:
|
sarahdayan
commented
Sep 6, 2023
| <div v-if="state" :class="suit()"> | ||
| <div | ||
| v-if="state" | ||
| :class="{ [suit()]: true, [suit('', 'noRefinement')]: state.nbPages <= 1 }" |
There was a problem hiding this comment.
This is additive, so it shouldn't be considered breaking IMO.
Worst case, if users have snapshot tests they can break, but this won't break production.
sarahdayan
commented
Sep 6, 2023
Comment on lines
+19
to
+20
| .replace(/(\s+)?<!---->(\s+)?/g, '') // Vue 2 | ||
| .replace(/(\s+)?<!--v-if-->(\s+)?/g, '') // Vue 3 |
There was a problem hiding this comment.
Vue also adds space after :table-flip:
sarahdayan
changed the base branch from
master
to
fix/pagination-modifier-click
sarahdayan
force-pushed
the
tests/pagination
branch
from
ac05f17 to
3557c75
Compare
sarahdayan
commented
Sep 6, 2023
| @@ -168,6 +168,7 @@ function PaginationLink({ | |||
| rootTagName="span" | |||
| rootProps={{ | |||
| className: cssClasses.link, | |||
| 'aria-label': ariaLabel, | |||
There was a problem hiding this comment.
This is additive, so it shouldn't be considered breaking IMO.
Worst case, if users have snapshot tests they can break, but this won't break production.
sarahdayan
requested review from
a team,
dhayab and
aymeric-giraudet
and removed request for
a team
dhayab
reviewed
Sep 7, 2023
sarahdayan
force-pushed
the
tests/pagination
branch
from
3557c75 to
451140d
Compare
dhayab
approved these changes
Sep 8, 2023
Haroenv
approved these changes
Sep 8, 2023
Haroenv
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the tests for the
paginationwidget to move them in the common test suite and reduce flavor-specific tests.https://algolia.atlassian.net/browse/FX-2516