Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pagination): add common test suite #5836

Merged
merged 12 commits into from
Sep 8, 2023
Merged

test(pagination): add common test suite #5836

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ca27036
fix(vue-instantsearch): prevent click on navigation items when holdin…
sarahdayan Sep 6, 2023
33d25bf
chore: increase bundle size
sarahdayan Sep 6, 2023
97171a6
refactor: use modifier
sarahdayan Sep 8, 2023
d6cbd56
test(pagination): add common test suite
sarahdayan Sep 6, 2023
451140d
test: remove unnecessary tests
sarahdayan Sep 6, 2023
3c87955
build: increase bundle size
sarahdayan Sep 8, 2023
5e0d4bb
test: lighten up tests
sarahdayan Sep 8, 2023
9feed20
style: lint
sarahdayan Sep 8, 2023
7cb864e
Merge branch 'master' into tests/pagination
sarahdayan Sep 8, 2023
28ae431
test: clean up InstantSearch.js tests
sarahdayan Sep 8, 2023
b58d7c9
seriously
sarahdayan Sep 8, 2023
f61c43f
chore: avoid linting Vue file
sarahdayan Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundlesize.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
{
"path": "packages/vue-instantsearch/vue3/umd/index.js",
"maxSize": "63.25 kB"
"maxSize": "63.5 kB"
},
{
"path": "packages/vue-instantsearch/vue2/cjs/index.js",
Expand Down
3 changes: 2 additions & 1 deletion packages/instantsearch.js/src/components/Pagination/Pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ function PaginationLink({
<li
className={cx(
cssClasses.item,
className,
Haroenv marked this conversation as resolved.
Show resolved Hide resolved
isDisabled && cssClasses.disabledItem,
className,
isSelected && cssClasses.selectedItem
)}
>
Expand All @@ -168,6 +168,7 @@ function PaginationLink({
rootTagName="span"
rootProps={{
className: cssClasses.link,
'aria-label': ariaLabel,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is additive, so it shouldn't be considered breaking IMO.

Worst case, if users have snapshot tests they can break, but this won't break production.

}}
templateKey={templateKey}
templates={templates}
Expand Down
146 changes: 0 additions & 146 deletions packages/instantsearch.js/src/components/Pagination/__tests__/Pagination-test.tsx
View file
Open in desktop

This file was deleted.

Loading