This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
Fix: Compute canRefine on the transformed items #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 111eb18 https://deploy-preview-1568--react-instantsearch.netlify.com |
samouss
suggested changes
Sep 15, 2018
|
@samouss yep, I can add those tests in the next couple of days. |
|
@samouss, better late than never :-). Just pushed up those new tests. |
samouss
approved these changes
Sep 25, 2018
|
One last change and we are ready to merge! You have to run Prettier to fix the style issue. Thanks a lot for your contributions! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1524
Summary
There was previously a bug where
canRefineprops were calculated based on untransformed item lists. This caused unintended behaviors such as a ClearRefinements button remaining active when a refinement being ignored via a filter intransformItemswas present.Result
This PR calculates
canRefineon the transformed list of items, correcting this behavior.