This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(PoweredBy): add a label to the Algolia logo #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
force-pushed
the
fix/poweredby-a11y
branch
from
a2eec84 to
1721382
Compare
|
Deploy preview ready! Built with commit 5b6532b |
The label says "Algolia", since the text before it is "powered by "
Haroenv
force-pushed
the
fix/poweredby-a11y
branch
from
1721382 to
5b6532b
Compare
|
Needs to be cherry-picked for v4.0 |
|
are you going to do it @mthuret ? |
|
Yes. |
mthuret
pushed a commit
that referenced
this pull request
Aug 3, 2017
<a name="4.1.0-beta.4"></a> # [4.1.0-beta.4](v4.1.0-beta.3...v4.1.0-beta.4) (2017-08-03) ### Bug Fixes * **deps:** Update dependency lint-staged to version ^4.0.0 (#201) ([6867a1b](6867a1b)) * **nextjs/ssr:** parse `params.asPath` (#189) ([ae17da0](ae17da0)) * **PoweredBy:** add a label to the Algolia logo (#216) ([cd235bd](cd235bd)) * **react:** remove typo around `"" 2` (#220) ([f73eb04](f73eb04)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([2d76022](2d76022)) * **theme:** format the count of items appearing in a refinement (#217) ([2225c24](2225c24))
marielaures
pushed a commit
that referenced
this pull request
Aug 3, 2017
<a name="4.1.0-beta.4"></a> # [4.1.0-beta.4](v4.1.0-beta.3...v4.1.0-beta.4) (2017-08-03) ### Bug Fixes * **deps:** Update dependency lint-staged to version ^4.0.0 (#201) ([6867a1b](6867a1b)) * **nextjs/ssr:** parse `params.asPath` (#189) ([ae17da0](ae17da0)) * **PoweredBy:** add a label to the Algolia logo (#216) ([cd235bd](cd235bd)) * **react:** remove typo around `"" 2` (#220) ([f73eb04](f73eb04)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([2d76022](2d76022)) * **theme:** format the count of items appearing in a refinement (#217) ([2225c24](2225c24))
marielaures
pushed a commit
that referenced
this pull request
Aug 7, 2017
<a name="4.1.0-beta.4"></a> # [4.1.0-beta.4](v4.1.0-beta.3...v4.1.0-beta.4) (2017-08-03) ### Bug Fixes * **deps:** Update dependency lint-staged to version ^4.0.0 (#201) ([6867a1b](6867a1b)) * **nextjs/ssr:** parse `params.asPath` (#189) ([ae17da0](ae17da0)) * **PoweredBy:** add a label to the Algolia logo (#216) ([cd235bd](cd235bd)) * **react:** remove typo around `"" 2` (#220) ([f73eb04](f73eb04)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([2d76022](2d76022)) * **theme:** format the count of items appearing in a refinement (#217) ([2225c24](2225c24))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Algolia logo in the PoweredBy component didn't have an
aria-label. This was noticed in #209 by @davidfurlong.Result
The label says "Algolia", since the text before it is "powered by "
fixes #209