This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(react): remove typo around "" 2
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linked to #213
Haroenv
suggested changes
Jul 28, 2017
| @@ -123,7 +123,7 @@ | |||
| margin-right: -4px; | |||
| height: 100%; | |||
| vertical-align: middle; | |||
| content: ''2 | |||
| content: '' | |||
There was a problem hiding this comment.
I think it was supposed to be a semicolon
|
Deploy preview ready! Built with commit fcc00c6 |
Haroenv
approved these changes
Jul 31, 2017
|
@oliviertassinari, how snapshots made by argos are updated? Will closing this PR enough? |
|
@mthuret You can always accept the diffs in order to get a green PR but that won't impact future PRs. We consider the screenshots accepted once merged. Also, Argos-CI tries to find the screenshots corresponding to the fork commit between the base branch and the compare one. |
|
When he can't find such fork commit, he fallback to the latest taken screenshots of the compare branch. |
|
The idea is to get a behavior as close as possible as if the screenshots were stored in git. |
mthuret
pushed a commit
that referenced
this pull request
Aug 3, 2017
mthuret
pushed a commit
that referenced
this pull request
Aug 3, 2017
<a name="4.0.10"></a> ## [4.0.10](v4.0.9...v4.0.10) (2017-08-03) ### Bug Fixes * **PoweredBy:** add a label to the Algolia logo ([2a6cf4f](2a6cf4f)) * **react:** remove typo around `"" 2` (#220) ([1e8af68](1e8af68)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([b97174e](b97174e)) * **theme:** format the count of items appearing in a refinement (#217) ([ed7c8d5](ed7c8d5))
mthuret
pushed a commit
that referenced
this pull request
Aug 3, 2017
<a name="4.1.0-beta.4"></a> # [4.1.0-beta.4](v4.1.0-beta.3...v4.1.0-beta.4) (2017-08-03) ### Bug Fixes * **deps:** Update dependency lint-staged to version ^4.0.0 (#201) ([6867a1b](6867a1b)) * **nextjs/ssr:** parse `params.asPath` (#189) ([ae17da0](ae17da0)) * **PoweredBy:** add a label to the Algolia logo (#216) ([cd235bd](cd235bd)) * **react:** remove typo around `"" 2` (#220) ([f73eb04](f73eb04)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([2d76022](2d76022)) * **theme:** format the count of items appearing in a refinement (#217) ([2225c24](2225c24))
marielaures
pushed a commit
that referenced
this pull request
Aug 3, 2017
<a name="4.1.0-beta.4"></a> # [4.1.0-beta.4](v4.1.0-beta.3...v4.1.0-beta.4) (2017-08-03) ### Bug Fixes * **deps:** Update dependency lint-staged to version ^4.0.0 (#201) ([6867a1b](6867a1b)) * **nextjs/ssr:** parse `params.asPath` (#189) ([ae17da0](ae17da0)) * **PoweredBy:** add a label to the Algolia logo (#216) ([cd235bd](cd235bd)) * **react:** remove typo around `"" 2` (#220) ([f73eb04](f73eb04)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([2d76022](2d76022)) * **theme:** format the count of items appearing in a refinement (#217) ([2225c24](2225c24))
marielaures
pushed a commit
that referenced
this pull request
Aug 7, 2017
<a name="4.1.0-beta.4"></a> # [4.1.0-beta.4](v4.1.0-beta.3...v4.1.0-beta.4) (2017-08-03) ### Bug Fixes * **deps:** Update dependency lint-staged to version ^4.0.0 (#201) ([6867a1b](6867a1b)) * **nextjs/ssr:** parse `params.asPath` (#189) ([ae17da0](ae17da0)) * **PoweredBy:** add a label to the Algolia logo (#216) ([cd235bd](cd235bd)) * **react:** remove typo around `"" 2` (#220) ([f73eb04](f73eb04)) * **ScrollTo:** scroll to only if change triggered by the widget observed (#202) ([2d76022](2d76022)) * **theme:** format the count of items appearing in a refinement (#217) ([2225c24](2225c24))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked to #213
Summary
Result