This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(connectToggle): use currentRefinement in metadata instead of the label #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-instantsearch ready! Built with commit 38f4f44 |
Haroenv
approved these changes
Jan 26, 2018
| @@ -109,14 +109,16 @@ export default createConnector({ | |||
| const checked = getCurrentRefinement(props, searchState, this.context); | |||
| const items = []; | |||
| const index = getIndex(this.context); | |||
|
|
|||
| if (checked) { | |||
| items.push({ | |||
There was a problem hiding this comment.
really weird conditional pushing IMO
There was a problem hiding this comment.
Which behaviour you will expect instead?
There was a problem hiding this comment.
const items = checked ? [{..stuff}] : []I'm not sure if it's that much better though
There was a problem hiding this comment.
Yep not sure, because the ternary will be split on several line.
| if (checked) { | ||
| items.push({ | ||
| label: props.label, | ||
| currentRefinement: props.label, | ||
| currentRefinement: checked, |
There was a problem hiding this comment.
makes sense wrt that issue
samouss
added a commit
that referenced
this pull request
Feb 6, 2018
<a name="4.5.0"></a> # [4.5.0](v4.4.2...v4.5.0) (2018-02-06) ### Bug Fixes * **connectRange:** use the same behaviour for currentRefinement in getMetadata ([#923](#923)) ([08917b6](08917b6)) * **connectToggle:** use currentRefinement in metadata instead of the label ([#909](#909)) ([89cae2b](89cae2b)) * **StarRatings:** always show the stars below ([#929](#929)) ([22bf93a](22bf93a)) ### Features * **connectStateResults:** expose isSearchStalled ([#933](#933)) ([f45ba27](f45ba27))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close partially #891