-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AVM: incentive opcodes #5984
AVM: incentive opcodes #5984
Conversation
Make migrate use VoteID.IsEmpty() Improve random accounts, especially for basics.Suspended Validate proposed absents, and suspend them.
v40 Use SelectionID to detect when to zero out StateProofID Simplify online account delta handling Fix expiration test
It was confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate topic: do we want to make a new REST endpoint for voting account data? It seems a bit odd that there's a reason to expose this stuff for on-chain contracts which wouldn't also apply to off-chain users as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5984 +/- ##
==========================================
- Coverage 56.13% 56.11% -0.02%
==========================================
Files 482 481 -1
Lines 68027 68074 +47
==========================================
+ Hits 38187 38203 +16
- Misses 27243 27273 +30
- Partials 2597 2598 +1 ☔ View full report in Codecov by Sentry. |
I guess so, because it's strange. On the other hand, I don't know if it's all that useful. I feel like we're adding these opcodes to fill a potential hole in the ability to make correct contracts that can do almost anything the in protocol incentive scheme can do. If you're off-chain, you have a lot of extra flexibility - For example you can record and use the old (balance round) information. |
Ok, that's convincing enough for now. At the very least, I don't think expanding the REST API should happen in this PR. |
Things I need for Reti at the moment (looks like 2 of the 4-5 are covered here) |
Adds AVM access to things that make sense for smart contracts related to block incentives.