-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Allow building with golang 1.21 #5989
Conversation
Also: bump github.com/libp2p/go-libp2p from 0.29.1 to 0.33.2 bump github.com/libp2p/go-libp2p-pubsub from 0.9.3 to 0.10.0. These need to be bumped because they depend on quic-go, which is sensitive to the version of golang used.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5989 +/- ##
==========================================
- Coverage 56.18% 56.14% -0.05%
==========================================
Files 482 482
Lines 67989 67989
==========================================
- Hits 38199 38170 -29
- Misses 27201 27223 +22
- Partials 2589 2596 +7 ☔ View full report in Codecov by Sentry. |
Hi there, Just ran this locally, think it is actually pretty close to being mergeable. I made one suggestion in the get_golang_version script to bump the MIN and SUPPORT versions. The other change is Thanks for your contribution @centromere ! |
Co-authored-by: Gary <982483+gmalouf@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you set the ARG GO_VERSION
in the Dockerfile to 1.21.9?
Going to handle this change in a separate PR.
Closing this (while incorporating the commits) in favor of #5994 |
Summary
These need to be bumped because they depend on quic-go, which is sensitive to the version of golang used.
Test Plan
make generate
,make sanity
, etc.