Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Allow building with golang 1.21 #5989

Closed
wants to merge 2 commits into from

Conversation

centromere
Copy link
Contributor

Summary

  • bump github.com/libp2p/go-libp2p from 0.29.1 to 0.33.2
  • bump github.com/libp2p/go-libp2p-pubsub from 0.9.3 to 0.10.0.

These need to be bumped because they depend on quic-go, which is sensitive to the version of golang used.

Test Plan

make generate, make sanity, etc.

Also:
bump github.com/libp2p/go-libp2p from 0.29.1 to 0.33.2
bump github.com/libp2p/go-libp2p-pubsub from 0.9.3 to 0.10.0.

These need to be bumped because they depend on quic-go, which is
sensitive to the version of golang used.
@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.14%. Comparing base (ff2c966) to head (9006729).
Report is 1 commits behind head on master.

❗ Current head 9006729 differs from pull request most recent head 4975013. Consider uploading reports for the commit 4975013 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5989      +/-   ##
==========================================
- Coverage   56.18%   56.14%   -0.05%     
==========================================
  Files         482      482              
  Lines       67989    67989              
==========================================
- Hits        38199    38170      -29     
- Misses      27201    27223      +22     
- Partials     2589     2596       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf self-assigned this May 6, 2024
@gmalouf
Copy link
Contributor

gmalouf commented May 6, 2024

Hi there,

Just ran this locally, think it is actually pretty close to being mergeable. I made one suggestion in the get_golang_version script to bump the MIN and SUPPORT versions. The other change is ARG GO_VERSION in the Dockerfile to 1.21.9.

Thanks for your contribution @centromere !

Co-authored-by: Gary <982483+gmalouf@users.noreply.github.com>
gmalouf
gmalouf previously requested changes May 6, 2024
Copy link
Contributor

@gmalouf gmalouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set the ARG GO_VERSION in the Dockerfile to 1.21.9?

@gmalouf gmalouf dismissed their stale review May 7, 2024 14:21

Going to handle this change in a separate PR.

@gmalouf gmalouf mentioned this pull request May 7, 2024
@gmalouf
Copy link
Contributor

gmalouf commented May 7, 2024

Closing this (while incorporating the commits) in favor of #5994

@gmalouf gmalouf closed this May 7, 2024
@centromere centromere deleted the support-go-1.21 branch May 7, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants