Build: Go 1.21 Support #5994
Merged
Build: Go 1.21 Support #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: bump github.com/libp2p/go-libp2p from 0.29.1 to 0.33.2 bump github.com/libp2p/go-libp2p-pubsub from 0.9.3 to 0.10.0. These need to be bumped because they depend on quic-go, which is sensitive to the version of golang used.
Co-authored-by: Gary <982483+gmalouf@users.noreply.github.com>
…ecessary changes for updated linter compliance.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5994 +/- ##
==========================================
- Coverage 56.18% 56.17% -0.01%
==========================================
Files 482 482
Lines 67989 67989
==========================================
- Hits 38199 38193 -6
- Misses 27201 27207 +6
Partials 2589 2589 ☔ View full report in Codecov by Sentry. |
gmalouf
requested review from
jasonpaulos and
algorandskiy
and removed request for
a team
jasonpaulos
reviewed
May 8, 2024
There was a problem hiding this comment.
This all looks correct to me, but I see 1.21.10 was released hours ago: https://groups.google.com/g/golang-announce/c/wkkO4P9stm0
I expect we should probably use that version
jasonpaulos
approved these changes
May 8, 2024
cce
approved these changes
May 8, 2024
algorandskiy
approved these changes
May 8, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Building on the work done as a part of #5989, this upgrades go-algorand to 1.21.10, including necessary linter and Dockerfile updates.
Test Plan
Existing tests/test suite all should pass.