Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyframe Selection: Add multi-threading and improve overall performances #1512

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Keyframe Selection: Add multi-threading and improve overall performances #1512

merged 5 commits into from
Aug 25, 2023

Commits on Aug 25, 2023

  1. [keyframe] Replace vectors containing scores with maps

    @cbentejac
    cbentejac committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a0d543f View commit details
    Browse the repository at this point in the history

  2. [keyframe] Set pixel aspect ratio for all output types 

    The pixel aspect ratio wasn't written in the output images' metadata if
they were written as JPEG because of an issue in OIIO. With the release
of version 2.4.13.0 of OIIO, this problem is solved and the correct pixel
aspect ratio value can now be propagated for JPEG images.
    @cbentejac
    cbentejac committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1051edb View commit details
    Browse the repository at this point in the history

  3. [keyframe] Sharpness computation: Move the sliding window faster 

    The sliding window for the sharpness computation was moving pixel by pixel,
which was costly computation-wise for limited extra accuracy.

The window is now moved windowSize / 4 by windowSize / 4 pixels, which
reduces the number of computations for an equivalent accuracy.
    @cbentejac
    cbentejac committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2d61581 View commit details
    Browse the repository at this point in the history

  4. [keyframe] Parallelize score computations with multi-threading

    @cbentejac
    cbentejac committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b9ce5ec View commit details
    Browse the repository at this point in the history

  5. [utils] KeyframeSelection: Set max number of threads and block size 

    Add a new argument to set the minimum number of frames that must be
processed by a thread for it to be spawned, and the maximum number of
threads that can be used.
    @cbentejac
    cbentejac committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b43dbbf View commit details
    Browse the repository at this point in the history